Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomials are evaluated twice (before multiopen and inside multiopen) #40

Open
kunxian-xia opened this issue Apr 7, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kunxian-xia
Copy link

The ProverQuery struct does not contain the evaluation of the poly at the point (which is already computed before we invoke the multiopen prover).

/// A polynomial query at a point
#[derive(Debug, Clone)]
pub struct ProverQuery<'com, C: CurveAffine> {
/// point at which polynomial is queried
pub(crate) point: C::Scalar,
/// coefficients of polynomial
pub(crate) poly: &'com Polynomial<C::Scalar, Coeff>,
/// blinding factor of polynomial
pub(crate) blind: Blind<C::Scalar>,
}

Then the multiopen prover will evaluate the polynomials again. Therefore, I suggest we add another field called eval of type C::Scalar in the ProverQuery struct.

@kunxian-xia kunxian-xia added the enhancement New feature or request label Apr 7, 2023
@kunxian-xia kunxian-xia self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant