Skip to content

Commit f1348bb

Browse files
committed
Use blocktime not blocknumber
1 parent a39317a commit f1348bb

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

accounts/abi/bind/backends/simulated.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ func (b *SimulatedBackend) callContract(ctx context.Context, call ethereum.CallM
640640
vmEnv := vm.NewEVM(evmContext, txContext, stateDB, b.config, vm.Config{NoBaseFee: true})
641641
gasPool := new(core.GasPool).AddGas(math.MaxUint64)
642642
signer := types.MakeSigner(b.blockchain.Config(), head.Number, head.Time)
643-
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, head.BaseFee, b.blockchain.Config(), signer, stateDB, head.Number)
643+
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, head.BaseFee, b.blockchain.Config(), signer, stateDB, head.Number, head.Time)
644644
if err != nil {
645645
return nil, err
646646
}

eth/tracers/api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ func (api *API) TraceCall(ctx context.Context, args ethapi.TransactionArgs, bloc
929929
}
930930

931931
signer := types.MakeSigner(api.backend.ChainConfig(), block.Number(), block.Time())
932-
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, block.BaseFee(), api.backend.ChainConfig(), signer, statedb, block.Number())
932+
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, block.BaseFee(), api.backend.ChainConfig(), signer, statedb, block.Number(), block.Time())
933933
if err != nil {
934934
return nil, err
935935
}

internal/ethapi/api.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -999,7 +999,7 @@ func EstimateL1MsgFee(ctx context.Context, b Backend, args TransactionArgs, bloc
999999
}()
10001000

10011001
signer := types.MakeSigner(config, header.Number, header.Time)
1002-
return fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, evm.StateDB, header.Number)
1002+
return fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, evm.StateDB, header.Number, header.Time)
10031003
}
10041004

10051005
func DoCall(ctx context.Context, b Backend, args TransactionArgs, blockNrOrHash rpc.BlockNumberOrHash, overrides *StateOverride, timeout time.Duration, globalGasCap uint64) (*core.ExecutionResult, error) {
@@ -1595,7 +1595,7 @@ func AccessList(ctx context.Context, b Backend, blockNrOrHash rpc.BlockNumberOrH
15951595
return nil, 0, nil, err
15961596
}
15971597
signer := types.MakeSigner(b.ChainConfig(), header.Number, header.Time)
1598-
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, b.ChainConfig(), signer, statedb, header.Number)
1598+
l1DataFee, err := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, b.ChainConfig(), signer, statedb, header.Number, header.Time)
15991599
if err != nil {
16001600
return nil, 0, nil, fmt.Errorf("failed to apply transaction: %v err: %v", args.toTransaction().Hash(), err)
16011601
}

les/odr_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ func odrContractCall(ctx context.Context, db ethdb.Database, config *params.Chai
145145
//vmenv := core.NewEnv(statedb, config, bc, msg, header, vm.Config{})
146146
gp := new(core.GasPool).AddGas(math.MaxUint64)
147147
signer := types.MakeSigner(config, header.Number, header.Time)
148-
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, statedb, header.Number)
148+
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, statedb, header.Number, header.Time)
149149
result, _ := core.ApplyMessage(vmenv, msg, gp, l1DataFee)
150150
res = append(res, result.Return()...)
151151
}
@@ -159,7 +159,7 @@ func odrContractCall(ctx context.Context, db ethdb.Database, config *params.Chai
159159
vmenv := vm.NewEVM(context, txContext, state, config, vm.Config{NoBaseFee: true})
160160
gp := new(core.GasPool).AddGas(math.MaxUint64)
161161
signer := types.MakeSigner(config, header.Number, header.Time)
162-
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, state, header.Number)
162+
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, state, header.Number, header.Time)
163163
result, _ := core.ApplyMessage(vmenv, msg, gp, l1DataFee)
164164
if state.Error() == nil {
165165
res = append(res, result.Return()...)

light/odr_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ func odrContractCall(ctx context.Context, db ethdb.Database, bc *core.BlockChain
201201
vmenv := vm.NewEVM(context, txContext, st, config, vm.Config{NoBaseFee: true})
202202
gp := new(core.GasPool).AddGas(math.MaxUint64)
203203
signer := types.MakeSigner(config, header.Number, header.Time)
204-
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, st, header.Number)
204+
l1DataFee, _ := fees.EstimateL1DataFeeForMessage(msg, header.BaseFee, config, signer, st, header.Number, header.Time)
205205
result, _ := core.ApplyMessage(vmenv, msg, gp, l1DataFee)
206206
res = append(res, result.Return()...)
207207
if st.Error() != nil {

rollup/fees/rollup_fee.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"bytes"
55
"math"
66
"math/big"
7+
"time"
78

89
"github.com/holiman/uint256"
910

@@ -62,7 +63,7 @@ type gpoState struct {
6263
blobScalar *big.Int
6364
}
6465

65-
func EstimateL1DataFeeForMessage(msg Message, baseFee *big.Int, config *params.ChainConfig, signer types.Signer, state StateDB, blockNumber *big.Int) (*big.Int, error) {
66+
func EstimateL1DataFeeForMessage(msg Message, baseFee *big.Int, config *params.ChainConfig, signer types.Signer, state StateDB, blockNumber *big.Int, blockTime uint64) (*big.Int, error) {
6667
if msg.IsL1MessageTx() {
6768
return big.NewInt(0), nil
6869
}
@@ -85,7 +86,7 @@ func EstimateL1DataFeeForMessage(msg Message, baseFee *big.Int, config *params.C
8586

8687
if !config.IsCurie(blockNumber) {
8788
rollupFee = calculateEncodedL1DataFee(raw, gpoState.overhead, gpoState.l1BaseFee, gpoState.scalar)
88-
} else if !config.IsFeynman(blockNumber) {
89+
} else if !config.IsFeynman(blockTime) {
8990
rollupFee = calculateEncodedL1DataFeeCurie(raw, gpoState.l1BaseFee, gpoState.l1BlobBaseFee, gpoState.commitScalar, gpoState.blobScalar)
9091
} else {
9192
rollupFee = calculateEncodedL1DataFeeFeynman(raw, gpoState.l1BaseFee, gpoState.l1BlobBaseFee, gpoState.commitScalar, gpoState.blobScalar)

0 commit comments

Comments
 (0)