Merge pull request #2 from scroll-tech/feat/basefold

adjust basefold visibility

Author: hero78119

Cargo.toml

@@ -32,7 +32,7 @@ poseidon = { path = "crates/poseidon", default-features = false }
 sumcheck_macro = { path = "crates/sumcheck_macro", default-features = false }
 transcript = { path = "crates/transcript", default-features = false }
 witness = { path = "crates/witness", default-features = false }
-whir = { path = "crates/whir", default-features = false }
+whir = { path = "crates/whir" }
 
 bincode = "1"
 clap = { version = "4.5", features = ["derive"] }

crates/mpcs/src/basefold.rs

@@ -18,20 +18,20 @@ use witness::RowMajorMatrix;
 use itertools::Itertools;
 use serde::{Serialize, de::DeserializeOwned};
 
-mod structure;
+pub mod structure;
 pub use structure::{
     Basefold, BasefoldCommitment, BasefoldCommitmentWithWitness, BasefoldDefault, BasefoldParams,
     BasefoldProverParams, BasefoldRSParams, BasefoldVerifierParams,
 };
-mod commit_phase;
+pub mod commit_phase;
 use commit_phase::batch_commit_phase;
-mod encoding;
+pub mod encoding;
 use multilinear_extensions::mle::ArcMultilinearExtension;
 
 #[cfg(debug_assertions)]
 use ff_ext::{Instrumented, PoseidonField};
 
-mod query_phase;
+pub mod query_phase;
 
 /// Implement the Polynomial Commitment Scheme present in the BaseFold paper
 /// https://eprint.iacr.org/2023/1705

crates/mpcs/src/basefold/structure.rs

@@ -90,11 +90,11 @@ pub struct BasefoldCommitmentWithWitness<E: ExtensionField>
 where
     E::BaseField: Serialize + DeserializeOwned,
 {
-    pub(crate) commit: Digest<E>,
-    pub(crate) codeword: MerkleTree<E::BaseField>,
+    pub commit: Digest<E>,
+    pub codeword: MerkleTree<E::BaseField>,
 
-    pub(crate) log2_max_codeword_size: usize,
-    pub(crate) polys: Vec<Vec<ArcMultilinearExtension<'static, E>>>,
+    pub log2_max_codeword_size: usize,
+    pub polys: Vec<Vec<ArcMultilinearExtension<'static, E>>>,
 }
 
 impl<E: ExtensionField> BasefoldCommitmentWithWitness<E>
@@ -264,11 +264,11 @@ pub struct BasefoldProof<E: ExtensionField>
 where
     E::BaseField: Serialize + DeserializeOwned,
 {
-    pub(crate) commits: Vec<Digest<E>>,
-    pub(crate) final_message: Vec<Vec<E>>,
-    pub(crate) query_opening_proof: QueryOpeningProofs<E>,
-    pub(crate) sumcheck_proof: Option<Vec<IOPProverMessage<E>>>,
-    pub(crate) pow_witness: E::BaseField,
+    pub commits: Vec<Digest<E>>,
+    pub final_message: Vec<Vec<E>>,
+    pub query_opening_proof: QueryOpeningProofs<E>,
+    pub sumcheck_proof: Option<Vec<IOPProverMessage<E>>>,
+    pub pow_witness: E::BaseField,
 }
 
 #[derive(Clone, Serialize, Deserialize)]
@@ -280,7 +280,7 @@ pub struct BasefoldCommitPhaseProof<E: ExtensionField>
 where
     E::BaseField: Serialize + DeserializeOwned,
 {
-    pub(crate) sumcheck_messages: Vec<IOPProverMessage<E>>,
-    pub(crate) commits: Vec<Digest<E>>,
-    pub(crate) final_message: Vec<Vec<E>>,
+    pub sumcheck_messages: Vec<IOPProverMessage<E>>,
+    pub commits: Vec<Digest<E>>,
+    pub final_message: Vec<Vec<E>>,
 }

crates/mpcs/src/lib.rs

@@ -261,7 +261,7 @@ pub enum Error {
     WhirError(whir_external::error::Error),
 }
 
-mod basefold;
+pub mod basefold;
 pub use basefold::{
     Basefold, BasefoldCommitment, BasefoldCommitmentWithWitness, BasefoldDefault, BasefoldParams,
     BasefoldRSParams, BasefoldSpec, EncodingScheme, RSCode, RSCodeDefaultSpec,