From ea9cdd9326cf811c7e08c0e6db76e668b00f265b Mon Sep 17 00:00:00 2001 From: physcocode Date: Sat, 31 Oct 2020 23:24:15 +0530 Subject: [PATCH] fix: Router now throws 404 error rather than resolving allIndex in unwanted situations --- src/RouterEngine.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/RouterEngine.php b/src/RouterEngine.php index f184026..37e2e7d 100644 --- a/src/RouterEngine.php +++ b/src/RouterEngine.php @@ -54,6 +54,7 @@ class RouterEngine */ private $dirMode = false; + /** * Store Dirctory during dir Mode */ @@ -187,7 +188,12 @@ private function setArguments() $classMethod = new \ReflectionMethod($controller, $this->method); if (count($arguments) < count($classMethod->getParameters())) { $this->error('Not enough arguments given to the method'); - } else { + } + // finally fix the long awaited allIndex bug ! + elseif (count($arguments) > count($classMethod->getParameters())) { + $this->error('Not able to resolve any method for'.$this->controller.'controller'); + } + else { $this->request->attributes->set('_arguments', implode(",", $arguments)); } }