Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Feature: specify target of add_action #244

Open
mmsheeks opened this issue Sep 25, 2013 · 4 comments
Open

Suggested Feature: specify target of add_action #244

mmsheeks opened this issue Sep 25, 2013 · 4 comments

Comments

@mmsheeks
Copy link

Just a thought, from time to time I include a "Preview" link using the add_action function. Would be useful to be able to specify target on the function call.

for example:

    $crud->add_action('Preview','IMG_URL','','ui-icon-plus', array($this, 'preview_click'), '_blank');
@Kaabi
Copy link
Contributor

Kaabi commented Sep 25, 2013

I guess you can already do that if you talking about Javascript function you can make the function by using css_class. but if you talking about running controller function so is already handled by the url_callback. but just having an option for previewing the image i guess is doesn't make any sense as already add_action already support both javascript/css or callback_url.

@mmsheeks
Copy link
Author

I'm not providing a preview option for just an image, I'm providing a preview for an entire webpage. I could add the function using Javascript triggers, yes, but it seemed like it would be a nice feature to have available in the code. And I can't imagine it's that difficult.

@Kaabi
Copy link
Contributor

Kaabi commented Sep 26, 2013

Sorry my bad, i didnt understand correctly the first post, you mean ahref target didn't see the _blank, yeah is gonna be useful option to define the href target

@mmsheeks
Copy link
Author

No worries! Glad to have clarified, hopefully that makes it easier for someone to understand what I was getting at, if it ever gets considered as a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants