Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using unset_edit_fields these fields disappear from the read page #238

Open
davidoster opened this issue Sep 4, 2013 · 6 comments
Open

Comments

@davidoster
Copy link

There has being a question about this here: http://www.grocerycrud.com/forums/topic/2015-unset-edit-fields-and-read-fields

Looking at the code, protected function showReadForm($state_info), line 1841
$data->fields = $this->get_edit_fields();

gets the read fields from the edit_fields. I believe it shoud be either from the columns or when full developed the read feature have the equivalent get_read_fields.

@scoumbourdis
Copy link
Owner

You are right :-( . I never thought about this issue. I will have it in mind so I can fix it.

Thanks
Johnny

@Nagasir
Copy link

Nagasir commented Mar 23, 2014

was it fixed ?? i have that problem too

@gulariav
Copy link

It is not fixed yet :(

@arif-rh
Copy link
Contributor

arif-rh commented Mar 28, 2014

It's has been fixed six months ago, check this 59f6545

arif-rh referenced this issue Mar 28, 2014
Add new functions:
- unset_read_fields.
- set_read_fields.
@gulariav
Copy link

Apologies, but it seems there is some differences in both files. I am using library package from website ( https://github.com/scoumbourdis/grocery-crud/archive/v1.4.1.zip ).

but the commit you mentioned is fixed. Thanks buddy :) 👍

@luiscoms
Copy link

There is no verion contron on the site.
With some bugfixes the good pratice is create a new tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants