-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated json doesn't have an array like in the README #26
Comments
Oh! Easier to change readme so it doesn’t change other’s expectations but I do prefer “files”. Might need a vote!
…---
Scott Stanfield
[email protected]
On Jan 17, 2018, at 9:06 PM, Galdin Raphael ***@***.***> wrote:
Command used:
m2j -o index.json -w 0 ./path/*.md
Expected output:
{
"files": [
{
"basename": "hey-there-delilah"
}
]
}
Actual output:
{
"hey-there-delilah": {
"basename": "hey-there-delilah"
}
}
Steps to reproduce:
git clone --branch content --depth 1 https://github.com/hymnsrepo/hymnsrepo-site.git
cd hymnsrepo-site
yarn add --dev markdown-to-json
./node_modules/.bin/m2j -o index.json -w 0 ./hymns/*.md
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
An alternative would be to use an array as the root (in the output): [
{
"basename": "hey-there-delilah"
}
] |
I'm worried about making a breaking change. It would be easier for me to update the readme than change working code. Thoughts? I'd like to close this one out. |
I think an array would make more sense than the current output. However if you don't feel strongly about it, feel free to close this. A breaking change would be a major version bump. If you get the time for a v1, do consider this then. (And let me know – I'd like to pitch in.) |
Good choice. Will fix on v6 over next few days. |
Command used:
m2j -o index.json -w 0 ./path/*.md
Expected output:
Actual output:
Steps to reproduce:
The text was updated successfully, but these errors were encountered: