Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button not functioning #393

Open
indrajithekanayake opened this issue Mar 24, 2020 · 7 comments
Open

Button not functioning #393

indrajithekanayake opened this issue Mar 24, 2020 · 7 comments

Comments

@indrajithekanayake
Copy link

Describe the bug
Back button not functioning in labller

To Reproduce
Steps to reproduce the behavior:

  1. Go to the dashboard
  2. Click on New project
  3. Give name and description for the project
  4. Go to project images and add new image.
  5. Click edit image and it will direct you to another dashboard
  6. Try to click the back button

Expected behavior
Either button should be removed or it should direct to the previous page

Screenshots
Capture

Desktop (please complete the following information):

  • OS: Windows10
  • Browser Chrome
  • Version latest
@thivatm
Copy link
Contributor

thivatm commented Mar 25, 2020

@SEMICOLON10 The back button is there for the purpose of navigating through images(In case if you have added multiple images in the project) did you check the button with multiple images added to the project?

@laksh22
Copy link
Collaborator

laksh22 commented Mar 27, 2020

Some suggestions:

  1. Don't show the Back button if the user is editing the first image in the list of images
  2. Don't show the Skip button if the user is editing the last image in the list of images
  3. Rename Back to Previous and Skip to Next. Sounds more intuitive

@SEMICOLON10 You can think about adding these features and making a PR

@indrajithekanayake
Copy link
Author

@thivatm @laksh22 thank you for the suggestions I ll start working on this

@temanisparsh
Copy link
Contributor

@laksh22 If this issue is not resolved yet, I would like to work on this.

@laksh22
Copy link
Collaborator

laksh22 commented Sep 26, 2020

@temanisparsh You can start if @SEMICOLON10 isn't working on this anymore

@temanisparsh
Copy link
Contributor

@laksh22 I worked on this and it looks like there is no way to be label multiple images at once. Even selecting multiple images in Project Images and then clicking Edit selects only a single image. In this case, I don't see the point of having these buttons at all. Please correct me if I am wrong.

@laksh22
Copy link
Collaborator

laksh22 commented Oct 2, 2020

@temanisparsh Yes, you can only edit one image at a time. Did you select multiple images by using the checkboxes? Those are just for deleting multiple images.

The point of the Back and Skip buttons is to cycle through the images you have added and edit them without having to go back to the Project Images in order to edit another image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants