Skip to content

Conversation

@scop
Copy link
Owner

@scop scop commented Nov 11, 2025

I'm consolidating my Renovate configs (and soon some other common things) to a common repo, cf. ref https://github.com/scop/common/blob/main/default.json

No plans to make any drastic changes and I'll update extending projects if I figure out I may be doing something in the common that conflicts with them.

Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/scop/common/blob/15a2f41a1d34caf81194d938020a7cf8e66a8f52/default.json#L17

I think .json doesn't allow code comments for ease of implementing a parser, though I'm not sure if the specific parser used by renovate is permissive about this.

@scop
Copy link
Owner Author

scop commented Nov 12, 2025

The usual JSON does not, however Renovate's parser does, and they explicitly recommend using the .json suffix when there are comments nevertheless (and they don't support .jsonc at least according to docs) 🤷

https://docs.renovatebot.com/configuration-options/

Renovate supports JSONC for .json files and any config files without file extension (e.g. .renovaterc). We also recommend you prefer using JSONC within a .json file to using a .json5 file if you want to add comments.

@scop scop merged commit 9afb270 into main Nov 12, 2025
10 checks passed
@scop scop deleted the chore/renovate-scop-common-preset branch November 12, 2025 19:20
Comment on lines 6 to 8
"ignorePresets": [
":dependencyDashboard",
":ignoreModulesAndTests",
":semanticPrefixFixDepsChoreOthers",
"docker:pinDigests"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this did not work the way I thought it would, it appears ignorePresets was overridden rather than being merged, as the dep dashboard popped up again, #589. Need to have a look.

@akinomyoga
Copy link
Collaborator

The usual JSON does not, however Renovate's parser does, and they explicitly recommend using the .json suffix when there are comments nevertheless (and they don't support .jsonc at least according to docs) 🤷

https://docs.renovatebot.com/configuration-options/

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants