fix(xfreerdp): Always try /list:kbd first

This caused failures on recent fedoradev rawhide tests, since it seems
to not be built with deprecated options like `/kbd-list` anymore.

This introduces an internal utility function to list kbd layouts, which
is used in two places.

Also stops trying `--kbd-list` whose last trace was removed in 2013:
FreeRDP/FreeRDP@9295838

Author: yedayak

completions/xfreerdp

@@ -1,14 +1,24 @@
 # xfreerdp completion                                      -*- shell-script -*-
 
+_comp_cmd_xfreerdp__kbd_list()
+{
+    local kbd_list
+    # Trying non deprecated /list:kbd first
+    kbd_list=$("$1" /list:kbd 2>/dev/null) ||
+        # Old syntax, deprecated in 2022-10-19
+        # See https://github.com/FreeRDP/FreeRDP/commit/119b8d4474ab8578101f86226e0d20a53460dd51
+        kbd_list=$("$1" /kbd-list 2>/dev/null)
+    _comp_awk '/^0x/ { print $1 }' <<<"$kbd_list"
+}
+
 _comp_cmd_xfreerdp()
 {
     local cur prev words cword comp_args
     _comp_initialize -n : -- "$@" || return
 
     case $prev in
         -k)
-            _comp_compgen_split -- "$("$1" --kbd-list |
-                _comp_awk '/^0x/ { print $1 }')"
+            _comp_compgen_split -- "$(_comp_cmd_xfreerdp__kbd_list "$1")"
             return
             ;;
         -a)
@@ -30,12 +40,7 @@ _comp_cmd_xfreerdp()
 
     case $cur in
         /kbd:*)
-            local kbd_list
-            kbd_list=$("$1" /kbd-list 2>/dev/null) ||
-                kbd_list=$("$1" /list:kbd 2>/dev/null)
-            _comp_compgen -c "${cur#/kbd:}" split -- "$(
-                _comp_awk '/^0x/ { print $1 }' <<<"$kbd_list"
-            )"
+            _comp_compgen -c "${cur#/kbd:}" split -- "$(_comp_cmd_xfreerdp__kbd_list "$1")"
             return
             ;;
         /bpp:*)