Merge pull request #511 from scodec/topic/equalsConstantTime

Add ByteVector#equalsConstantTime

Author: mpilquist

core/shared/src/main/scala/scodec/bits/ByteVector.scala

@@ -1293,6 +1293,21 @@ sealed abstract class ByteVector
       case _                => false
     }
 
+  /** Like [[equals]] but compares all bytes instead of returning after first non-matching byte.
+    * @group collection
+    */
+  def equalsConstantTime(other: ByteVector): Boolean =
+    if (this.size != other.size) false
+    else {
+      var result, idx = 0
+      val s = this.size
+      while (idx < s) {
+        result = result | (this(idx) ^ other(idx))
+        idx += 1
+      }
+      result == 0
+    }
+
   /** Display the size and bytes of this `ByteVector`. For bit vectors beyond a certain size, only a
     * hash of the contents are shown.
     * @group collection

core/shared/src/test/scala/scodec/bits/ByteVectorTest.scala

@@ -59,6 +59,13 @@ class ByteVectorTest extends BitsSuite {
     forAll((b: ByteVector, b2: ByteVector) => assert((b == b2) == (b === b2)))
   }
 
+  property("equalsConstantTime") {
+    forAll(bytesWithIndex) { case (b, m) =>
+      assert((b.take(m) ++ b.drop(m)).equalsConstantTime(b))
+    } &&
+    forAll((b: ByteVector, b2: ByteVector) => assert((b === b2) == (b.equalsConstantTime(b2))))
+  }
+
   test("compact is a no-op for already compact byte vectors") {
     val b = ByteVector(0x80)
     assert((b.compact eq b.compact) == true)