Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Reviewed) Uncertainty Modeling with SymPy Stats #19

Open
mmckerns opened this issue Jun 21, 2014 · 2 comments
Open

(Reviewed) Uncertainty Modeling with SymPy Stats #19

mmckerns opened this issue Jun 21, 2014 · 2 comments

Comments

@mmckerns
Copy link

Reviewer:
Michael McKerns
the Uncertainty Quantification Foundation
Arcadia, California, USA

Area of Expertiese: It's uncertain.

General Evaluation

  • Quality of the approach: meets
  • Quality of the writing: meets
  • Quality of the figures/tables: meets

Specific Evaluation

  • Is the code made publicly available and does the article sufficiently describe how to access it?

    Yes.

  • Does the article present the problem in an appropriate context?

    Yes.

  • Is the content of the paper accessible to a computational scientist with no specific knowledge in the given field?

    For as "math-y" as the topic is, the author makes it as accessible as possible.

  • Does the paper describe a well-formulated scientific or technical achievement?

    Yes.

  • Are the technical and scientific decisions well-motivated and clearly explained?

    Yes.

  • Are the code examples (if any) sound, clear, and well-written?

    Yes.

  • Is the paper factually correct?

    As far as I can tell.

  • Is the language and grammar of sufficient quality?

    Yes. It's actually excellently written.

  • Are the conclusions justified?

    Yes.

  • Is prior work properly and fully cited?

    This could use some improvement. There are similar ideas that both exist in python code and have been published, but there are no references to included. For example, some the capacity presented exists in mystic (reviewer's shameless plug) as well as some Bayesian python codes, and in tools outside of Python. Also, there are mentions of CUDA, BLAS, LAPACK, MPI, and so on that should have references. The point being, this work was not done in a bubble.

  • Should any part of the article be shortened or expanded? Please explain.

    No.

  • In your view, is the paper fit for publication in the conference proceedings?

    This is one of the better scientific articles I've read in quite a while, not just scientific computing, but science in general. So, in a word, yes.

@ahmadia
Copy link
Member

ahmadia commented Jun 21, 2014

cc @mrocklin

@mrocklin
Copy link

Glad you enjoyed it Mike.

The point about references is well taken, my reference habits were pretty abysmal then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants