Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: Algorithms to Determine Asteroid’s Physical Properties using Sparse and Dense Photometry, Robotic Telescopes and Open Data #940

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

Spacegirl123
Copy link
Contributor

@Spacegirl123 Spacegirl123 commented Jun 8, 2024

If you are creating this PR in order to submit a draft of your paper, please name your PR with Paper: <title>. An editor will then add a paper label and GitHub Actions will be run to check and build your paper.

See the project readme for more information.

Editor: Chris Calloway @cbcunc

Reviewers:

@ameyxd ameyxd self-assigned this Jun 8, 2024
@ameyxd ameyxd added the paper This indicates that the PR in question is a paper label Jun 8, 2024
@ameyxd ameyxd removed their assignment Jun 11, 2024
@cbcunc cbcunc self-assigned this Jun 11, 2024
Copy link

github-actions bot commented Jun 12, 2024

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/Arushi_Nath 🔍 Inspect 28 checks passed (1 optional) Jul 22, 2024, 11:35 PM

@kalyan678
Copy link
Collaborator

@Spacegirl123 - Hello, My name is Kalyan , a Data and AI scientist from India. With extensive experience in tackling machine learning and artificial intelligence challenges at the enterprise level across diverse domains, I am thrilled to review your paper for the SciPy Conference. This is my second year in a row reviewing for the conference, and I look forward to offering valuable suggestions and inputs to refine your paper, ensuring it effectively reaches and benefits a broader audience.

@kalyan678
Copy link
Collaborator

kalyan678 commented Jun 20, 2024

Hi @Spacegirl123 Below are some points that you can incorporate in order to improve the abstract. Let me know if you have any questions.

  1. I think it is good to explain briefly why understanding near-Earth asteroids is important.
  2. What's the advantage of being open source algorithm. Write a short line about it.
  3. I think it is also good to describe how your algorithms combine continuous and infrequent light data.
  4. Try simplifying or briefly explaining terms like "absolute magnitude," "rubble-pile strength," and "S-type composition" for broader understanding.
  5. It is good to mention how the reduced orbital period measurement contributes to planetary defense efforts.

Introduction & Goals:

The introduction stays on track with its story. It explains the difficulties and aims clearly, without making things more complicated than they need to be. Good job!

If possible simplify terms like "phase curves" and provide quick explanations.

Regarding the goals, they are well-defined and commendable. However, it would be beneficial to elaborate more on how the developed methodology (PhAst) will be used in planetary defense tests such as NASA’s DART mission.

Additionally, please clarify how characterizing asteroid populations will help us better understand the diversity of compositions in the solar system.

Methodology :

The methodology section is clear and concise, however I think you can describe how the algorithm integrates different data types. Include a brief overview or diagram of the workflow to make the process more transparent.

Data Integration:

In my opinion, It is good to explain how data from different sources are combined.

Observational Process:

Overall the process details are good. Consider adding diagrams or flowcharts to visually represent the observational process, which can help readers better understand the sequence and interaction of steps.

Case Study- Didymos Binary Asteroid:

The initial observations of the Didymos binary asteroid are well-detailed, including its size, albedo, rotation period, and composition. This gives a good starting point for understanding the asteroid's properties. Well done!

Results:

Please clarify if the processing time includes data retrieval and pre-processing? Also, provide a brief context for the listed physical properties for the NASA LUCY and UAE missions' targets to show their relevance.

Future work:

The future applications of PhAst are promising. May be we can mention specific benefits or new opportunities these applications might bring.

General Suggestions:

  • Avoid or simplify technical terms where possible. Provide brief explanations for any unavoidable technical jargon.

  • Consider adding diagrams, flowcharts, or graphs to make complex processes and data patterns clearer.

  • Try to use specific examples or scenarios to illustrate key points, such as how asteroid strength is determined or the implications of the taxonomy data.

  • Please ensure a consistent narrative flow and structure throughout the sections for easier understanding and readability.

This concludes my initial review. Happy to clarify/ discuss if you have any questions on my comments. Good luck!

@kalyan678
Copy link
Collaborator

Hi @Spacegirl123 - The introduction stays on track with its story. It explains the difficulties and aims clearly, without making things more complicated than they need to be. Good job!

If possible simplify terms like "phase curves" and provide quick explanations.

Regarding the goals, they are well-defined and commendable. However, it would be beneficial to elaborate more on how the developed methodology (PhAst) will be used in planetary defense tests such as NASA’s DART mission.

Additionally, please clarify how characterizing asteroid populations will help us better understand the diversity of compositions in the solar system.

@cbcunc
Copy link
Member

cbcunc commented Jun 20, 2024

Review reminders sent to @chuchugo and @kalyan678

@chuchugo
Copy link

Hi @Spacegirl123 Thanks for your paper. After reading the paper, here are some suggestions regarding the improvement. Hope you find it helpful.

General Comments

  • The paper discusses measurements on phase angles of asteroids. The author combines sparse photometry from surveys and dense photometry from citizens to determine asteroids' albedo, size, rotation, strength, and composition. Didymos binary asteroid and combined them with GAIA etc. surveys. Measured 35-minute decrease in the mutual orbital period after impact by the DART mission.

  • The paper seems to be incomplete. Please explain your algorithm, figures, mathematical definitions, equations, etc.. If a key part of the algorithm has already been published, please summarize the key steps and give a full citation in the references. The goal is to make the paper reproducible. Without completeness and reproducibility, it is impossible to review it and also difficult to learn from it. Hope it can be revised in a more solidated way since you probably have a nice algorithm that astronomers can use. I will give some specific comments below, but they all point to this general comment.

Specific Comments

  • Organization:

    • The organization is a little difficult to follow as a research paper, and is more written like a blog post. For instance, the definition "Dense and Sparse Photometry" does not need to be a separate section. Same with "Goals" - these should both be in the introduction.
    • Banner figure axes were not labeled
    • The references are confusing. Please use a standardized reporting format, such as IEEE, and reference them one by one using brackets [1], [2] etc.
  • Verifiability:

    • Many claims are unsubstantiated. For instance, "Asteroid strength can be inferred from the rotation period. If the rotation period is less than 2.2 hours, the asteroid must be a strength-bound single rock. Otherwise, it would fly apart." How was this determined? What other sources use this criteria? What fundamental equations point to this requirement?
  • Computational content and Technical content:

    • "Over 58% of the asteroids characterized by PhAst are carbonaceous, showing they are the most abundant type in our Solar System." -- Is this a new discovery you are presenting, or is this a generally known fact? It seems rather odd to present such a fundamental finding in an off-hand way in the middle of a conference presentation.
    • Please include the relevant data, key algorithm steps, and the code so it can be validated
  • Clarity:

    • Most readers will not be subject-matter experts on astronomy. As such, please define key astronomical terms such as "albedo", H, G.
    • The introduction does not adequately survey the field showing other alternatives and recent progress toward solving the stated problem problem (integrating sparse and dense datasets)
    • Please explain the figures. I cannot find references to any of the figures in the paper. Nor can I find captions for the figures

@cbcunc
Copy link
Member

cbcunc commented Jun 25, 2024

@chuchugo and @kalyan678 you may also open a review on this PR to line by line make suggestions and comments more specifically. That way when the author resolves a review comment or suggestion, we can know how much progress is being made to address your concerns.

@cbcunc cbcunc assigned chuchugo and unassigned chuchugo Jul 2, 2024
@cbcunc cbcunc requested a review from kalyan678 July 2, 2024 16:31
@kalyan678
Copy link
Collaborator

@chuchugo and @kalyan678 you may also open a review on this PR to line by line make suggestions and comments more specifically. That way when the author resolves a review comment or suggestion, we can know how much progress is being made to address your concerns.

@cbcunc - I have already provided my initial review section wise as per the paper. I hope that helps the author to understand the context and work accordingly. Let me know if there are any questions!

@Spacegirl123
Copy link
Contributor Author

Hello,

I have addressed all the reviews in my updated paper. I wanted to change my image files and banner since they do not match with my text, but GitHub is not letting me remove them/add new ones. The edit and delete buttons are greyed out. Could you let me know how I can change them?

Best regards,
Arushi

papers/Arushi_Nath/main.md Outdated Show resolved Hide resolved
@cbcunc
Copy link
Member

cbcunc commented Jul 14, 2024

Hello,

I have addressed all the reviews in my updated paper. I wanted to change my image files and banner since they do not match with my text, but GitHub is not letting me remove them/add new ones. The edit and delete buttons are greyed out. Could you let me know how I can change them?

Best regards, Arushi

@Spacegirl123 Do you mean you are not able to make new commits to your Spacegirl123:2024 branch?

@cbcunc
Copy link
Member

cbcunc commented Jul 20, 2024

@Spacegirl123 ^^^

@Spacegirl123
Copy link
Contributor Author

Hello,
I have addressed all the reviews in my updated paper. I wanted to change my image files and banner since they do not match with my text, but GitHub is not letting me remove them/add new ones. The edit and delete buttons are greyed out. Could you let me know how I can change them?
Best regards, Arushi

@Spacegirl123 Do you mean you are not able to make new commits to your Spacegirl123:2024 branch?

I am able to make commits, but not to the .png files. See attached.
ScipyGit

@fwkoch
Copy link
Collaborator

fwkoch commented Jul 22, 2024

@Spacegirl123 - If you want to delete the file using the web interface, you must go the branch in your fork and delete from over there:

image

@Spacegirl123
Copy link
Contributor Author

@Spacegirl123 - If you want to delete the file using the web interface, you must go the branch in your fork and delete from over there:

image

Thanks. I have edited all my figures.

Copy link
Collaborator

@kalyan678 kalyan678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for responding late. I can see that you’ve made the changes based on the feedback, and they look great. Overall, it's excellent work. Wishing you the best of luck moving forward!

@cbcunc cbcunc merged commit f8ef723 into scipy-conference:2024 Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants