Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong paper built if author's fork's branch contains more than one paper #59

Open
cbcunc opened this issue Jul 17, 2022 · 0 comments
Open
Assignees

Comments

@cbcunc
Copy link
Member

cbcunc commented Jul 17, 2022

Sometimes authors merge the canonical branch into their scipy_proceedings fork's branch. When they do so, builder.BuildManager.build_paper() builds the wrong paper. This is because the BuildManager.paper property manager incorrectly assumes that the author's paper is the only unexcluded paper in the author's fork's branch:

return papers[0].split('/')[-1]

Determine another method for selecting the author's paper from the author's branch and implement it into builder.BuildManager.

@cbcunc cbcunc self-assigned this Jul 17, 2022
@cbcunc cbcunc changed the title Wrong paper built if author branch contains more than one paper Wrong paper built if author fork contains more than one paper Jul 17, 2022
@cbcunc cbcunc changed the title Wrong paper built if author fork contains more than one paper Wrong paper built if author fork's branch contains more than one paper Jul 17, 2022
@cbcunc cbcunc changed the title Wrong paper built if author fork's branch contains more than one paper Wrong paper built if author's fork's branch contains more than one paper Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant