Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Manifest #262

Closed
cendolinside123 opened this issue Feb 6, 2024 · 11 comments
Closed

Privacy Manifest #262

cendolinside123 opened this issue Feb 6, 2024 · 11 comments

Comments

@cendolinside123
Copy link
Contributor

From Apple docs :

Starting in spring 2024, you must include the privacy manifest for any SDK listed below when you submit new apps in App Store Connect that include those SDKs, or when you submit an app update that adds one of the listed SDKs as part of the update. Signatures are also required in these cases where the listed SDKs are used as binary dependencies.

Could you please add a privacy manifest for this library?

@scinfu
Copy link
Owner

scinfu commented Feb 13, 2024

Do you know where can i find an example?
This library do not use any data.

@cendolinside123
Copy link
Contributor Author

Do you know where can i find an example? This library do not use any data.

Actualy I don't realy know what data need or what apple API that use on this app.

Some Privacy manifest example baybe can be seen on
https://github.com/cendolinside123/IGListKit/tree/Jan/Privacy-Manifest-Support-Main-Branch

@cendolinside123
Copy link
Contributor Author

@cendolinside123
Copy link
Contributor Author

we have updated to the latest pod with SwiftSoup (2.7.1). we can see the Privacy Manifest file. The root case is declared wrong format. So we get this error when we generate the privacy report.

Screenshot 2024-03-04 at 12 15 08 in the afternoon Privacy Manifest is must change to like this /*

NSPrivacyTracking NSPrivacyTrackingDomains NSPrivacyCollectedDataTypes NSPrivacyAccessedAPITypes
*/ So the issues is fixed after change like above. COuld you update the code for that?

Screenshot 2024-03-04 at 12 55 03 like this one?

@takmorgaming
Copy link

takmorgaming commented Mar 4, 2024

update to like this
Screenshot 2024-03-04 at 12 59 28 in the afternoon

@cendolinside123
Copy link
Contributor Author

takmorgaming

I see, look like XML issue when I generate value

@cendolinside123
Copy link
Contributor Author

cendolinside123 commented Mar 4, 2024

update to like this Screenshot 2024-03-04 at 12 59 28 in the afternoon

thanks for the report, already do pull request. Waiting the owner to approve @scinfu

@kapitoshka438
Copy link

kapitoshka438 commented Mar 15, 2024

@scinfu I may be wrong but you don't need to add a privacy manifest at all if your library doesn't collect any tracking or non-tracking data and doesn't use any of APIs needed to be describes in the manifest. In other words, if your manifest is empty just don't add it. The latest version 2.7.1 has invalid manifest and I would recommend to just remove it and release the fix.
Снимок экрана 2024-03-15 в 19 53 00

Or just review and approve this pr #264 it makes it work

@scinfu
Copy link
Owner

scinfu commented Mar 18, 2024

released in 2.7.2
thank you

@scinfu scinfu closed this as completed Mar 18, 2024
@radu2lupu
Copy link

I got the following error back from Apple. I am on 2.7.5 version of the library.
image

@jonasman
Copy link

Got the same today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants