Skip to content

Commit dd2ed56

Browse files
committed
get_coordinates: fix concatenation syntax
Having "+ xxx" on a new line looked like valid syntax at first glance but of course is not. The concatenation was just resolving as independent lines of code and never actually adding versions or classifiers to the jgo coordinates. This resulted in all lists of the same components hashing to the same string, regardless of those component versions. Closes #68
1 parent dca14fc commit dd2ed56

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

jgo/jgo.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,10 @@ def dependency_string(self):
132132
return xml
133133

134134
def get_coordinates(self):
135-
return [self.groupId, self.artifactId]
136-
+([self.version] if self.version != VERSION_MANAGED else [])
137-
+([self.classifier] if self.classifier else [])
135+
return ([self.groupId, self.artifactId]
136+
+ ([self.version] if self.version != Endpoint.VERSION_MANAGED else [])
137+
+ ([self.classifier] if self.classifier else [])
138+
)
138139

139140
def is_endpoint(string):
140141
endpoint_elements = (

0 commit comments

Comments
 (0)