Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need token for h5py #51

Closed
larsoner opened this issue Jan 22, 2024 · 10 comments
Closed

Need token for h5py #51

larsoner opened this issue Jan 22, 2024 · 10 comments
Assignees

Comments

@larsoner
Copy link

See h5py/h5py#2355, @tupui I assume this is where you wanted me to open an issue? Sounds like @stefanv might have already pinged @jarrodmillman as well

@tupui
Copy link
Member

tupui commented Jan 22, 2024

Hi @larsoner, yes this is the correct place.

I am +1 for giving the access as it's a fairly notorious package. I would not be surprised that it could be used in some CI and help you there. @larsoner do you have some rational to support that?

@scientific-python/nightly-wheels-developers what do you think?

If all are in favour, @larsoner who should get access? (Anaconda handles)

EDIT: feel free to send me a DM for that if wanted.

@larsoner
Copy link
Author

h5py is a pandas extra so it's a blocker for some testing, yeah. @tacaswell do you know what Anaconda handles should get access (see above 👆 )

@tupui
Copy link
Member

tupui commented Jan 22, 2024

Oh I did not realise that indeed, then I guess there is not much discussion to have 😄

@tacaswell
Copy link

probably atleast me (@tacaswell ) and @takluyver ?


Sorry for dropping the ball on this @larsoner I got as far as sorting out I no longer had the power to make API tokens my self and that an issues like this needed to be opened. I then got lost sorting out where to open said issue and here we are.

@matthewfeickert
Copy link
Member

@scientific-python/nightly-wheels-developers what do you think?

Oh I did not realise that indeed, then I guess there is not much discussion to have

Getting to this late, but I agree with @tupui's assesment here and so am +1 to moving this forward.

However, given the discussion that has been ongoing on Issue #45, #30 (comment), etc. about core pacakges and use of the Anaconda Cloud channel, can the @scientific-python/spec-steering-committee please either formally add h5py as a core package (which would be my vote as someone external to the committee) or provide some guidance that can be turned into documentaion on how they see packages that aren't core packages being given access to the channel storage resources?

To be clear, I do not want to slow down the process of moving forward for h5py at all. I would just like clear guidelines that can be consistently pointed to in the future on use.

@tupui
Copy link
Member

tupui commented Jan 23, 2024

One immediate line we could draw is that this library is needed by a core library for full testing. To me that seems like a reasonable perimeter. But we should be careful not to "go down too much" the dependency tree.

For the protocol, I will wait for one more +1 and create the ressources.

@bsipocz
Copy link
Member

bsipocz commented Jan 23, 2024

One immediate line we could draw is that this library is needed by a core library for full testing.

If that will be the policy, then we'll need to bring in a lot of libraries indeed. (looking at the extras dependencies of a few libraries e.g. xarray, mpl, etc, the list to include in this channel will be very long). This is not to say that h5py should not be here (I'm +/-0 on it), just that having this as a policy may not be as easy/clear-cut as it seems.

@stefanv
Copy link
Member

stefanv commented Jan 23, 2024

Can we continue this discussion on #30, and use this issue to handle the h5py token?

@larsoner
Copy link
Author

Done in #30 (comment)

@matthewfeickert
Copy link
Member

matthewfeickert commented Feb 22, 2024

@larsoner @tacaswell @takluyver Good news, we have the approval (#30 (comment)) to add h5py to the nightly wheels Anaconda Cloud org https://anaconda.org/scientific-python-nightly-wheels/ !

To get started on this can @tacaswell and @takluyver (and @larsoner too if you also want upload permissions/responsibility) please do the following:

Steps to gain upload access to https://anaconda.org/scientific-python-nightly-wheels/

image

If you'd also like to use the scientific/upload-nightly-action GitHub Action that this repository provides please check out this repo's README. If you need to collect wheels from different CI jobs, consider creating a new GitHub Actions workflow with logic similar to matplotlib's or Awkward's.

If you have any questions please just ask here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants