Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on supported Python versions #55

Open
jarrodmillman opened this issue Dec 6, 2023 · 3 comments
Open

Add section on supported Python versions #55

jarrodmillman opened this issue Dec 6, 2023 · 3 comments
Labels
type: Enhancement New feature or request

Comments

@jarrodmillman
Copy link
Member

It would be nice to add the option to include supported Python versions from the classifiers. For example, see

Maybe a flag?

@lagru
Copy link
Member

lagru commented Dec 7, 2023

Easy to implement now that we got the parsing of pyproject.toml already in-place.

However, this seems very similar to what was discussed in #18. In #18 (review) (ff) @bsipocz and you are not convinced that listing minimal dependencies is necessary. What makes listing supported Python versions more important than say NumPy or the full set of dependencies?

To be clear I don't mind including this as feature at all. I'd make it an optional feature. If we limit the scope to parsing pyproject.toml and agree on formatting details this will be a simple feature to add and maintain.

@lagru lagru added the type: Enhancement New feature or request label Dec 7, 2023
@lagru
Copy link
Member

lagru commented Dec 7, 2023

Also some overlap with #16.

@lagru
Copy link
Member

lagru commented Jun 3, 2024

After talking @bsipocz and @jarrodmillman, current consensus is:

  • Just grab the minimal Python version and runtime dependencies from the pyproject.toml if present and paste into its own section. Including the Python version, and dependencies should be two independent configuration options, so projects can opt-in / opt-out.
  • Do the same for optional dependencies which are named in a third config option.
  • Long-term we might want a lightweight plugin-system or at least some Python-scriptable customization. Though, I'd argue to wait until we have at least some feature requests or ideas to know what such a system would have to support. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants