Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit new contributors #12

Open
stefanv opened this issue Jul 1, 2023 · 1 comment
Open

Credit new contributors #12

stefanv opened this issue Jul 1, 2023 · 1 comment

Comments

@stefanv
Copy link
Member

stefanv commented Jul 1, 2023

The release notes generator we used previously generated credit for new contributors:

New Contributors

 • @some-person-name made their first contribution in #57

This would be nice to have!

@lagru
Copy link
Member

lagru commented Jul 4, 2023

Highlighting new contributors would indeed be very useful. GitHub already does this on the UI level so maybe there's a GraphQL or API way to query this property directly. Do you remember how the previous solution handled this problem?

Otherwise, the hard part is arriving at a complete set of all previous contributors to compare to. Just parsing the full history seems very expensive.

A performant but a bit annoying solution might be something like

  • Add a --previous-contributors FILE option. It expects a simple CSV file (or similar) with ideally the databaseId of users. Login would work as well (and should be included), but might break down if users rename themselves.
  • Add a --append-new-contributors FILE option which appends contributors which aren't already in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants