Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.net 5.0 excessive dependencies #19

Closed
picturelink opened this issue Jan 27, 2021 · 9 comments · Fixed by #24
Closed

.net 5.0 excessive dependencies #19

picturelink opened this issue Jan 27, 2021 · 9 comments · Fixed by #24

Comments

@picturelink
Copy link

I went to install this on a .net 5.0 project that I'm working on, and the list of dependencies seems to be excessive. I guess this is because the package only targets .NETFramework and .NETStandard.

PictureLink.WebApi

Updates:

Microsoft.NETCore.Platforms.1.0.1 -> Microsoft.NETCore.Platforms.1.1.0
Microsoft.NETCore.Targets.1.0.1 -> Microsoft.NETCore.Targets.1.1.0
runtime.native.System.4.0.0 -> runtime.native.System.4.3.0
System.AppContext.4.1.0 -> System.AppContext.4.3.0
System.Collections.4.0.11 -> System.Collections.4.3.0
System.Diagnostics.Debug.4.0.11 -> System.Diagnostics.Debug.4.3.0
System.Globalization.4.0.11 -> System.Globalization.4.3.0
System.IO.4.1.0 -> System.IO.4.3.0
System.IO.FileSystem.4.0.1 -> System.IO.FileSystem.4.3.0
System.IO.FileSystem.Primitives.4.0.1 -> System.IO.FileSystem.Primitives.4.3.0
System.Linq.4.1.0 -> System.Linq.4.3.0
System.Linq.Expressions.4.1.0 -> System.Linq.Expressions.4.3.0
System.ObjectModel.4.0.12 -> System.ObjectModel.4.3.0
System.Reflection.4.1.0 -> System.Reflection.4.3.0
System.Reflection.Emit.ILGeneration.4.0.1 -> System.Reflection.Emit.ILGeneration.4.3.0
System.Reflection.Emit.Lightweight.4.0.1 -> System.Reflection.Emit.Lightweight.4.3.0
System.Reflection.Extensions.4.0.1 -> System.Reflection.Extensions.4.3.0
System.Reflection.Primitives.4.0.1 -> System.Reflection.Primitives.4.3.0
System.Reflection.TypeExtensions.4.1.0 -> System.Reflection.TypeExtensions.4.3.0
System.Resources.ResourceManager.4.0.1 -> System.Resources.ResourceManager.4.3.0
System.Runtime.4.1.0 -> System.Runtime.4.3.0
System.Runtime.Extensions.4.1.0 -> System.Runtime.Extensions.4.3.0
System.Runtime.Handles.4.0.1 -> System.Runtime.Handles.4.3.0
System.Runtime.InteropServices.4.1.0 -> System.Runtime.InteropServices.4.3.0
System.Runtime.InteropServices.RuntimeInformation.4.0.0 -> System.Runtime.InteropServices.RuntimeInformation.4.3.0
System.Text.Encoding.4.0.11 -> System.Text.Encoding.4.3.0
System.Threading.4.0.11 -> System.Threading.4.3.0
System.Threading.Tasks.4.0.11 -> System.Threading.Tasks.4.3.0

Installing:

ISO3166.1.0.3
Microsoft.Win32.Primitives.4.3.0
NETStandard.Library.1.6.1
runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.native.System.IO.Compression.4.3.0
runtime.native.System.Net.Http.4.3.0
runtime.native.System.Security.Cryptography.Apple.4.3.0
runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple.4.3.0
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
System.Buffers.4.3.0
System.Collections.Concurrent.4.3.0
System.Console.4.3.0
System.Diagnostics.Tools.4.3.0
System.Diagnostics.Tracing.4.3.0
System.Globalization.Calendars.4.3.0
System.Globalization.Extensions.4.3.0
System.IO.Compression.4.3.0
System.IO.Compression.ZipFile.4.3.0
System.Net.Http.4.3.0
System.Net.Primitives.4.3.0
System.Net.Sockets.4.3.0
System.Runtime.Numerics.4.3.0
System.Security.Cryptography.Algorithms.4.3.0
System.Security.Cryptography.Csp.4.3.0
System.Security.Cryptography.Encoding.4.3.0
System.Security.Cryptography.OpenSsl.4.3.0
System.Security.Cryptography.Primitives.4.3.0
System.Security.Cryptography.X509Certificates.4.3.0
System.Text.Encoding.Extensions.4.3.0
System.Text.RegularExpressions.4.3.0
System.Threading.Tasks.Extensions.4.3.0
System.Threading.Timer.4.3.0
System.Xml.ReaderWriter.4.3.0
System.Xml.XDocument.4.3.0
@304NotModified
Copy link
Contributor

304NotModified commented Mar 15, 2022 •
edited
Loading

ow yes, this lib should also target .NET Standard 2

@schourode would a PR accepted for this? It isn't a large change

@schourode
Copy link
Owner

@304NotModified Absolutely!

@304NotModified 304NotModified mentioned this issue Mar 23, 2022
Merged
@304NotModified
Copy link
Contributor

--> #24

@schourode
Copy link
Owner

GitHub auto-closed this issue when I merged the pull request, but I believe we are not quite done yet, as the new build yet has to be pushed to NuGet.

@304NotModified Is that something you would be up for helping with? It has been quite a few years since I last uploaded anything there, and I don't quite recall the process (which may also have changed since) 😑

@schourode schourode reopened this Mar 24, 2022
@304NotModified
Copy link
Contributor

@schourode sure, will try to respond with the steps in the next days

@andersnm
Copy link
Collaborator

andersnm commented Mar 25, 2022 •
edited
Loading

@schourode It's basically drag and drop; download the file from the buildserver, login to nuget, click upload, and drag the file into the upload zone. :) All required form fields should be prepopulated from the Nuget metadata.

Ensure to bump version number in the project file before. Previous releases did not use tags, but has some benefits.

(There are some failure points, f.ex several times Nuget tightened their package validation rules, so had to make further changes before release)

@304NotModified
Copy link
Contributor

304NotModified commented Mar 26, 2022 •
edited
Loading

I think its better to publish from appveyor directly, its more transparent

@304NotModified
Copy link
Contributor

@schourode see steps here: #28

@schourode
Copy link
Owner

Release 1.0.4 has been published, including all of the changes from @304NotModified. I believe this release should address also the issue reported here, so I will close this one now. Let me know if this is misunderstood.

Thanks a million, @304NotModified ! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.NET Standard 2.0 support 304NotModified/iso3166
3 participants
@schourode @304NotModified @andersnm