Reduce GlobalScope usage

[skalarproduktraum]

For concurrency, scenery uses GlobalScope is a few places, which is discouraged now.
A better solution for this needs to be found. Maybe @elect86 or @altavir have suggestions 😎

[elect86]

I wish I could help with coroutines, but I still haven't used them enough to be familiar with :/

[altavir]

The GlobalScope is indeed a bad practice. The good practice is to create a scope for your application and pass it explicitly where you need it. Could you give links to places in question, or we can plan an online session to discuss that.

[skalarproduktraum]

scenery/src/main/kotlin/graphics/scenery/DefaultNode.kt

Line 61 in 795acc3

GlobalScope.launch {

How about this one? The intention there is to invoke a lambda asynchronously when a new Node is added.

Edit: Pasted wrong URL first. D'oh.

[altavir]

I don't understand what this line does. Looks like it just assigned a field to itself.

[altavir]

You probably wanted to link to something like

scenery/src/main/kotlin/graphics/scenery/DefaultNode.kt

Line 61 in f6aedc1

GlobalScope.launch {

And it is indeed not good. If the process is long, the structured concurrency is broken here. You need to provide a scope for such operations. Pass it as a parameter or store it in the Node.