Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bf: UTAPI-105 UtapiReindex: use list of redis sentinels #1305

Merged
merged 2 commits into from
Jun 27, 2024
Merged

bf: UTAPI-105 UtapiReindex: use list of redis sentinels #1305

merged 2 commits into from
Jun 27, 2024

Conversation

jonathan-gramain
Copy link
Contributor

Use a list of Redis sentinels that are running on stateful nodes only, instead of localhost.

Previously, a stateless-only node wouldn't have a local sentinel no running, causing UtapiReindex to fail.

Added a failover mechanism in case of connection error on the current sentinel, to try each other one in turn.

@jonathan-gramain
bf: UTAPI-105 UtapiReindex: use list of redis sentinels
426dfd0 
Use a list of Redis sentinels that are running on stateful nodes only,
instead of localhost.

Previously, a stateless-only node wouldn't have a local sentinel node
running, causing UtapiReindex to fail.

Added a failover mechanism in case of connection error on the current
sentinel, to try each other one in turn.
@jonathan-gramain
UTAPI-105 bump version
88d18f3
@bert-e
Copy link
Contributor

bert-e commented Jun 25, 2024

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 25, 2024

Incorrect fix version

The Fix Version/s in issue UTAPI-105 contains:

  • 7.10.16

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.17

  • 7.70.5

  • 8.1.15

Please check the Fix Version/s of UTAPI-105, or the target
branch of this pull request.

@jonathan-gramain
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Jun 25, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@jonathan-gramain
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/bugfix/UTAPI-105-useListOfSentinelNodes with contents from bugfix/UTAPI-105-useListOfSentinelNodes
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/bugfix/UTAPI-105-useListOfSentinelNodes origin/development/7.70
 $ git merge origin/bugfix/UTAPI-105-useListOfSentinelNodes
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/bugfix/UTAPI-105-useListOfSentinelNodes

The following options are set: create_integration_branches

@jonathan-gramain
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

Conflict

A conflict has been raised during the creation of
integration branch w/8.1/bugfix/UTAPI-105-useListOfSentinelNodes with contents from w/7.70/bugfix/UTAPI-105-useListOfSentinelNodes
and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/bugfix/UTAPI-105-useListOfSentinelNodes origin/development/8.1
 $ git merge origin/w/7.70/bugfix/UTAPI-105-useListOfSentinelNodes
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/bugfix/UTAPI-105-useListOfSentinelNodes

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue UTAPI-105.

Goodbye jonathan-gramain.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit 88d18f3 into development/7.10 Jun 27, 2024
14 checks passed
@bert-e bert-e deleted the bugfix/UTAPI-105-useListOfSentinelNodes branch June 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

@nicolas2bert nicolas2bert nicolas2bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-gramain @bert-e @nicolas2bert @BourgoisMickael