Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core-ui Component refactoring #326

Open
5 of 9 tasks
ChengYanJin opened this issue May 10, 2021 · 0 comments
Open
5 of 9 tasks

Core-ui Component refactoring #326

ChengYanJin opened this issue May 10, 2021 · 0 comments
Labels
debt technical debt

Comments

@ChengYanJin
Copy link
Contributor

ChengYanJin commented May 10, 2021

Component: All the components

Why this is needed:

  • Currently we have too many styles override in the various UIs.
  • Responsive font/units is missinig
  • Keyboard navigation is broken for various components (dropdown, tabs, ...)

What should be done:

  • text component
  • spacing (marging, padding)
  • link
  • button
  • select
  • scrollable tabs
  • table
    - [x] singleSelectable table
    - [ ] add search bar
    - [ ] multiSelectable table
  • chart (Vega-lite)
  • mediam and percentile chart

...more components are coming!

https://docs.google.com/document/d/1gZgZtcJtUZQlpN7H4zJhyeDK-c2w6y2UlaPGyGdqTpk/edit

Implementation proposal (strongly recommended):
Technical requirement:

  • Require strongly typing
  • The variant of the components should cover over 90% of use cases

Test plan:
TBD

@ChengYanJin ChengYanJin added the debt technical debt label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt technical debt
Projects
None yet
Development

No branches or pull requests

1 participant