Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework srb_init_disk() #68

Open
Joacchim opened this issue Nov 26, 2014 · 0 comments
Open

Rework srb_init_disk() #68

Joacchim opened this issue Nov 26, 2014 · 0 comments

Comments

@Joacchim
Copy link
Contributor

the function is a bundle of spagetthi that might bite us in the ass later:

  • Error management is done case-by-case instead of in a cleanup section (no transactional way)
  • Attempt to free the disk on line 511 from the device, while it's only assigned later on line 518
  • and other friends...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant