fix(baremetal): switch to env var

Author: Laure-di

internal/namespaces/baremetal/v1/custom_server_create_test.go

@@ -7,13 +7,14 @@ import (
 	"github.com/scaleway/scaleway-cli/v2/core"
 	"github.com/scaleway/scaleway-cli/v2/internal/namespaces/baremetal/v1"
 	baremetalSDK "github.com/scaleway/scaleway-sdk-go/api/baremetal/v1"
+	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/stretchr/testify/assert"
 )
 
-const (
-	offerNameNVME = "EM-I215E-NVME"
-	offerNameSATA = "EM-B111X-SATA"
-	zone          = "fr-par-2"
+var (
+	offerNameNVME = getenv("OFFER_NAME_NVME", "EM-I215E-NVME")
+	offerNameSATA = getenv("OFFER_NAME_SATA", "EM-B111X-SATA")
+	zone          = getenv("zone", "fr-par-2")
 )
 
 // All test below should succeed to create an instance.
@@ -26,7 +27,7 @@ func Test_CreateServer(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameNVME,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")
@@ -51,7 +52,7 @@ func Test_CreateServer(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameNVME,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")
@@ -82,7 +83,7 @@ func Test_CreateServer(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameNVME,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")

internal/namespaces/baremetal/v1/custom_server_fip_test.go

@@ -9,6 +9,7 @@ import (
 	"github.com/scaleway/scaleway-cli/v2/internal/namespaces/baremetal/v1"
 	flexibleip "github.com/scaleway/scaleway-cli/v2/internal/namespaces/flexibleip/v1alpha1"
 	baremetalSDK "github.com/scaleway/scaleway-sdk-go/api/baremetal/v1"
+	"github.com/scaleway/scaleway-sdk-go/scw"
 )
 
 func Test_CreateFlexibleIPInteractive(t *testing.T) {
@@ -25,7 +26,7 @@ func Test_CreateFlexibleIPInteractive(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameNVME,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")
@@ -58,7 +59,7 @@ func Test_CreateFlexibleIP(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameNVME,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")

internal/namespaces/baremetal/v1/custom_server_install_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/scaleway/scaleway-cli/v2/internal/namespaces/baremetal/v1"
 	iam "github.com/scaleway/scaleway-cli/v2/internal/namespaces/iam/v1alpha1"
 	baremetalSDK "github.com/scaleway/scaleway-sdk-go/api/baremetal/v1"
+	"github.com/scaleway/scaleway-sdk-go/scw"
 )
 
 func Test_InstallServer(t *testing.T) {
@@ -25,7 +26,7 @@ func Test_InstallServer(t *testing.T) {
 					api := baremetalSDK.NewAPI(ctx.Client)
 					server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 						OfferName: offerNameNVME,
-						Zone:      zone,
+						Zone:      scw.Zone(zone),
 					})
 					if server.Stock != baremetalSDK.OfferStockAvailable {
 						err := errors.New("offer out of stock")
@@ -57,7 +58,7 @@ func Test_InstallServer(t *testing.T) {
 					api := baremetalSDK.NewAPI(ctx.Client)
 					server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 						OfferName: offerNameNVME,
-						Zone:      zone,
+						Zone:      scw.Zone(zone),
 					})
 					if server.Stock != baremetalSDK.OfferStockAvailable {
 						return errors.New("offer out of stock")

internal/namespaces/baremetal/v1/custom_server_test.go

@@ -17,7 +17,7 @@ func Test_StartServerErrors(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameSATA,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")
@@ -58,7 +58,7 @@ func Test_StopServerErrors(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameSATA,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")
@@ -99,7 +99,7 @@ func Test_RebootServerErrors(t *testing.T) {
 				api := baremetalSDK.NewAPI(ctx.Client)
 				server, _ := api.GetOfferByName(&baremetalSDK.GetOfferByNameRequest{
 					OfferName: offerNameSATA,
-					Zone:      zone,
+					Zone:      scw.Zone(zone),
 				})
 				if server.Stock != baremetalSDK.OfferStockAvailable {
 					return errors.New("offer out of stock")

internal/namespaces/baremetal/v1/helpers_test.go

@@ -2,10 +2,20 @@ package baremetal_test
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/scaleway/scaleway-cli/v2/core"
 )
 
+func getenv(key, fallback string) string {
+	value := os.Getenv(key)
+	if len(value) == 0 {
+		return fallback
+	}
+
+	return value
+}
+
 // createServerAndWait creates a baremetal instance
 // register it in the context Meta at metaKey.
 func createServerAndWait() core.BeforeFunc {