Correctly catch async exceptions in FileSystemDataVault (#9016)

fm3 · web-flow · commit e96e38105798 · 2025-10-27T08:47:21.000+01:00
Got a ton of exception warnings in the logs because the exceptions
weren’t correctly captured into the Fox.

Fox.fromFutureBox assumes that there is no exception in the future
itself. This is not what is needed here.
diff --git a/webknossos-datastore/app/com/scalableminds/webknossos/datastore/datavault/FileSystemDataVault.scala b/webknossos-datastore/app/com/scalableminds/webknossos/datastore/datavault/FileSystemDataVault.scala
@@ -74,7 +74,10 @@ class FileSystemDataVault extends DataVault with FoxImplicits {
         if (channel != null && channel.isOpen) channel.close()
     }
 
-    Fox.fromFutureBox(promise.future)
+    for {
+      box <- Fox.fromFuture(promise.future)
+      result <- box.toFox
+    } yield result
   }
 
   override def listDirectory(path: VaultPath, maxItems: Int)(implicit ec: ExecutionContext): Fox[List[VaultPath]] =

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,10 @@ class FileSystemDataVault extends DataVault with FoxImplicits {`
`74`	`74`	`if (channel != null && channel.isOpen) channel.close()`
`75`	`75`	`}`
`76`	`76`
`77`		`- Fox.fromFutureBox(promise.future)`
	`77`	`+ for {`
	`78`	`+ box <- Fox.fromFuture(promise.future)`
	`79`	`+ result <- box.toFox`
	`80`	`+ } yield result`
`78`	`81`	`}`
`79`	`82`
`80`	`83`	`override def listDirectory(path: VaultPath, maxItems: Int)(implicit ec: ExecutionContext): Fox[List[VaultPath]] =`