Remove isScratch banner (#8296)

* remove isscratch banner

* update changelog

* remove isScratch from datastore public json

* remove isscratch from frontend

* update snapshots

---------

Co-authored-by: Florian M <[email protected]>

Author: philippotto

CHANGELOG.unreleased.md

@@ -43,5 +43,6 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 
 ### Removed
 - Removed support for HTTP API versions 3 and 4. [#8075](https://github.com/scalableminds/webknossos/pull/8075)
+- Removed that a warning is shown when a dataset is served from a datastore that was marked with isScratch=true. [#8296](https://github.com/scalableminds/webknossos/pull/8296)
 
 ### Breaking Changes

app/models/dataset/DataStore.scala

@@ -71,7 +71,6 @@ class DataStoreService @Inject()(dataStoreDAO: DataStoreDAO, jobService: JobServ
       Json.obj(
         "name" -> dataStore.name,
         "url" -> dataStore.publicUrl,
-        "isScratch" -> dataStore.isScratch,
         "allowsUpload" -> dataStore.allowsUpload,
         "jobsSupportedByAvailableWorkers" -> Json.toJson(jobsSupportedByAvailableWorkers),
         "jobsEnabled" -> jobsEnabled

frontend/javascripts/oxalis/default_state.ts

@@ -143,7 +143,6 @@ const defaultState: OxalisState = {
     dataStore: {
       name: "localhost",
       url: "http://localhost:9000",
-      isScratch: false,
       allowsUpload: true,
       jobsEnabled: false,
       jobsSupportedByAvailableWorkers: [],

frontend/javascripts/oxalis/view/layouting/tracing_layout_view.tsx

@@ -1,5 +1,4 @@
-import { WarningFilled } from "@ant-design/icons";
-import { Alert, Layout, Tooltip } from "antd";
+import { Layout } from "antd";
 import ErrorHandling from "libs/error_handling";
 import Request from "libs/request";
 import Toast from "libs/toast";
@@ -256,8 +255,7 @@ class TracingLayoutView extends React.PureComponent<PropsWithRouter, State> {
       this.props.is2d,
     );
     const currentLayoutNames = this.getLayoutNamesFromCurrentView(layoutType);
-    const { isDatasetOnScratchVolume, isUpdateTracingAllowed, distanceMeasurementTooltipPosition } =
-      this.props;
+    const { isUpdateTracingAllowed, distanceMeasurementTooltipPosition } = this.props;
 
     const createNewTracing = async (
       files: Array<File>,
@@ -322,31 +320,6 @@ class TracingLayoutView extends React.PureComponent<PropsWithRouter, State> {
                       autoSaveLayouts: this.props.autoSaveLayouts,
                     }}
                   />
-                  {isDatasetOnScratchVolume ? (
-                    <Tooltip title={messages["dataset.is_scratch"]}>
-                      <Alert
-                        className="hide-on-small-screen"
-                        style={{
-                          height: 30,
-                          paddingTop: 4,
-                          backgroundColor: "var(--ant-color-warning)",
-                          border: "none",
-                          color: "white",
-                        }}
-                        message={
-                          <span>
-                            Dataset is on tmpscratch!{" "}
-                            <WarningFilled
-                              style={{
-                                margin: "0 0 0 6px",
-                              }}
-                            />
-                          </span>
-                        }
-                        type="error"
-                      />
-                    </Tooltip>
-                  ) : null}
                 </div>
               ) : null}
             </RenderToPortal>
@@ -401,7 +374,6 @@ function mapStateToProps(state: OxalisState) {
     isUpdateTracingAllowed: state.tracing.restrictions.allowUpdate,
     showVersionRestore: state.uiInformation.showVersionRestore,
     storedLayouts: state.uiInformation.storedLayouts,
-    isDatasetOnScratchVolume: state.dataset.dataStore.isScratch,
     datasetId: state.dataset.id,
     is2d: is2dDataset(state.dataset),
     displayName: state.tracing.name ? state.tracing.name : state.dataset.name,

frontend/javascripts/test/fixtures/dataset_server_object.ts

@@ -66,7 +66,6 @@ const apiDataset: APIDataset = {
   dataStore: {
     name: "localhost",
     url: "http://localhost:9000",
-    isScratch: false,
     allowsUpload: true,
     jobsSupportedByAvailableWorkers: [],
     jobsEnabled: false,

frontend/javascripts/test/fixtures/skeletontracing_server_objects.ts

@@ -187,7 +187,6 @@ export const annotation: APIAnnotation = {
   dataStore: {
     name: "localhost",
     url: "http://localhost:9000",
-    isScratch: false,
     allowsUpload: true,
     jobsEnabled: false,
     jobsSupportedByAvailableWorkers: [],

frontend/javascripts/test/fixtures/tasktracing_server_objects.ts

@@ -130,7 +130,6 @@ export const annotation: APIAnnotation = {
   dataStore: {
     name: "localhost",
     url: "http://localhost:9000",
-    isScratch: false,
     allowsUpload: true,
     jobsEnabled: false,
     jobsSupportedByAvailableWorkers: [],

frontend/javascripts/test/fixtures/volumetracing_server_objects.ts

@@ -96,7 +96,6 @@ export const annotation: APIAnnotation = {
   dataStore: {
     name: "localhost",
     url: "http://localhost:9000",
-    isScratch: false,
     allowsUpload: true,
     jobsEnabled: false,
     jobsSupportedByAvailableWorkers: [],

frontend/javascripts/test/snapshots/public-test/test-bundle/test/backend-snapshot-tests/annotations.e2e.js.md

@@ -26,7 +26,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -150,7 +149,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -390,7 +388,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -564,7 +561,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -745,7 +741,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -872,7 +867,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -1001,7 +995,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: '2012-06-28_Cortex',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',
@@ -1125,7 +1118,6 @@ Generated by [AVA](https://avajs.dev).
       dataSetName: 'confocal-multi_knossos',
       dataStore: {
         allowsUpload: true,
-        isScratch: false,
         jobsEnabled: false,
         jobsSupportedByAvailableWorkers: [],
         name: 'localhost',