Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove examples from tests #1229

Closed
wants to merge 3 commits into from
Closed

Remove examples from tests #1229

wants to merge 3 commits into from
+3,742 −0

Conversation

markbader
Copy link
Contributor

Description:

  • The examples should contain less code for testing. This should increase readability and make the examples easier to use.

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

Add tests for things that are only tested in the examples:

  • test apply_merger_mode
  • test

@markbader markbader self-assigned this Dec 11, 2024
normanrz added a commit that referenced this pull request Dec 13, 2024
@normanrz
merge with #1229
acee240
@normanrz normanrz mentioned this pull request Dec 13, 2024
Merged
2 tasks
@normanrz
Copy link
Member

Since #1174 is merged now, shall we close this?

@markbader markbader closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markbader markbader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance examples usability
2 participants
@markbader @normanrz