Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: map name position to desugared version of named context bound #22374

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: map name position to desugared version of named context bound #22374

wants to merge 2 commits into from
+39 −12

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jan 15, 2025 •
edited
Loading

resolves: #22335
This PR changes the positions so context bound name position is correctly mapped in the desugaring:

def aa[T : Numeric as num]() = ??? // original code
def aa[T >: Nothing <: Any]()(using num: Numeric[T]): Nothing = ??? // desugared code, where position of `num` points to `num` in the original code

This also affects the cases where context bound is not named. The definition position of evidence$0 changed:

def aa[T : Numeric]() = ??? // original code
def aa[T >: Nothing <: Any]()(using evidence$0: Numeric[T]): Nothing = ??? // desugared code
// previously position of evidence$0 in original code
def aa[T : <<>>Numeric]() = ???
// after this PR
def aa[T : Numeric<<>>]() = ???

Which I think makes sense since if the was a name it would go after the context bound

@Gedochao Gedochao requested a review from dwijnand January 17, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand Awaiting requested review from dwijnand

At least 1 approving review is required to merge this pull request.

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No hover for named context bound
2 participants
@kasiaMarek @dwijnand