Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination behaviour of &, &&, |, ||, / #33

Open
AndreVanDelft opened this issue Feb 11, 2016 · 0 comments
Open

Termination behaviour of &, &&, |, ||, / #33

AndreVanDelft opened this issue Feb 11, 2016 · 0 comments

Comments

@AndreVanDelft
Copy link
Contributor

Normally n-ary nodes are deactivated when they have no children any more.
This is done in line 451 of ContinuationHandler.scala:

if (node.children.isEmpty) insertDeactivation(node, null)

However, for operators &, &&, |, ||, / part of the children may be optional:
activated after a break?, and no atomic actions have yet happened therein.

The deactivation test should only take the set of other nodes into account;
when this test is matched the optionally activated children should be removed.

The code should have clear comments that explains what is being done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant