Charges Overview Error

[arakla]

One of the columns, either Pending Charges or Total is not always accurate. I think pending charges doesn't actually total all pending charges.

[brucethesloth]

@arakla Could you be more descriptive of the problem? i.e. Does this happen on the charges page? Thanks!

[pkoenig10]

I'm pretty sure the issue @arakla noticed was as result of not accounting for the case when the is_approved scope for a charge is nil, rather than 'true' or 'false'. See app/models/charge.rb.

This is an issue that probably exists in multiple places (see my fix for another instance here) and in fixing this issue we should go through all models to fix this wherever it occurs.

I don't really like the solution I used in that commit. We really should fix this by either:

1. Using where.not. This is not the best solution because it not clear to contributors not familiar with this issue why that needs to be used and will likely result in this issue reappearing in the future.
2. Enforcing this non-nullability in the SQL schema and use default values. I think this is the correct way to solve the problem. The SQL schema provides a declarative way to define these constraints.

[arakla]

I am referring to the charge overview view, which is located here: https://[Server]/charge_overview
The view is located here: binder-app/app/views/home/charge_overview.html.erb

And what @pkoenig10 points out sounds like the culprit.

As mentioned in #215, it is not referenced anywhere and is effectively just passed on by word of mouth or looking at the code (which is a separate issue).