Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide opt out from changes to libraryDependencies #45

Open
bchallenor opened this issue Apr 19, 2017 · 0 comments
Open

Provide opt out from changes to libraryDependencies #45

bchallenor opened this issue Apr 19, 2017 · 0 comments

Comments

@bchallenor
Copy link

Would it be possible to provide an opt out from changes to libraryDependencies? I am shading the protobuf-java jar into my own jar and renaming its packages, so I don't want the vanilla jar added to libraryDependencies.

My preference would be for the plugin to not change libraryDependencies by default; it seems inconsistent to delegate that responsibility to the plugin given that the user is responsible for providing a protoc of a matching version. Without the libraryDependencies feature, the plugin would be independent of the protoc version. Its scope would be simply to watch .proto files and invoke the user's protoc when they change. But if backwards compatibility is a concern, it might require another setting to disable the existing behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant