Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert stats about unknown words into statistics_documentstatistic #94

Open
egli opened this issue May 19, 2021 · 1 comment · May be fixed by #100
Open

Insert stats about unknown words into statistics_documentstatistic #94

egli opened this issue May 19, 2021 · 1 comment · May be fixed by #100
Projects
Word Statistics

Comments

@egli
Copy link
Member

egli commented May 19, 2021

The old system used to insert the number of total words and unknown words into a separate table statistics_documentstatistic
@egli egli added this to To do in May release May 19, 2021
@egli egli moved this from To do to In progress in May release May 19, 2021
@egli egli closed this as completed in 05dfff2 May 20, 2021
@egli egli moved this from In progress to Done in May release May 20, 2021
egli added a commit that referenced this issue May 20, 2021
@egli
Add number of total and unknown words to the stats table
f545169 
Fixes #94
@egli
Copy link
Member Author

egli commented May 20, 2021

Well unfortunately the commit above doesn't work as it does a select with a limit of 20, so the number of unknown words is always 20 😞 . There is a commit (25354d5) which rectifies this problem, but it is ugly, so I moved it to a branch.

Let's look at this again after the db migration to aggregated tables.

@egli egli reopened this May 20, 2021
@egli egli moved this from Done to To do in May release May 20, 2021
@egli egli removed this from To do in May release May 20, 2021
@egli egli added this to To do in DB Migration Aug 3, 2021
@egli egli added this to the 0.8.14 milestone Aug 3, 2021
@egli egli moved this from To do to In progress in DB Migration Aug 3, 2021
@egli egli moved this from In progress to To do in DB Migration Aug 5, 2021
@egli egli linked a pull request Aug 5, 2021 that will close this issue
Bring back word statistics #100
Draft
@egli egli removed this from the 0.8.14 milestone Aug 16, 2021
@egli egli added this to To do in Word Statistics Aug 30, 2021
@egli egli removed this from To do in DB Migration Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Word Statistics
Status: To do
Word Statistics
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back word statistics sbsdev/daisyproducer2
1 participant
@egli