Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double say and disconnect #14

Closed
ghost opened this issue Dec 6, 2011 · 7 comments
Closed

Double say and disconnect #14

ghost opened this issue Dec 6, 2011 · 7 comments

Comments

@ghost
Copy link

ghost commented Dec 6, 2011

Sometimes when i call phenny.say(), my bot says the data twice and then disconnects. This happens both phenny bots i run from time to time.

@sbp
Copy link
Owner

sbp commented Dec 7, 2011

I have known phenny.say() to send the data twice, very rarely, but not to then disconnect. I think that the data duplication bug is something to do with threading, but I've not been able to isolate it, and because it only happens so very rarely I haven't tried to do so. If you succeed in finding reproducible conditions for the bug, please do note them here.

@eka
Copy link
Contributor

eka commented Feb 15, 2012

The duplication is happening to me too.

@sbp
Copy link
Owner

sbp commented Feb 15, 2012

What python version and OS are you both using? How often does this happen, quantitatively? Is your bug only duplication, eka, or does the disconnect happen too?

@eka
Copy link
Contributor

eka commented Feb 15, 2012

Only duplication. Not happening all the time.

Python 2.7.2+ (default, Oct 4 2011, 20:06:09)
[GCC 4.6.1] on linux2

OS: Linux jaganath 3.0.0-12-generic #20-Ubuntu SMP Fri Oct 7 14:56:25 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
Linux Mint 12

@ghost
Copy link
Author

ghost commented Feb 15, 2012

I actually stopped using phenny a few weeks after posting this because of the dupe/disconnect. It did disconnect for me after almost every dupe.

Python 2.7, 3.1.9-2-ARCH

@sbp
Copy link
Owner

sbp commented May 7, 2012

Hopefully fixed in 8a0d0dd thanks to @theli-ua and tanto.

@sbp sbp closed this as completed May 7, 2012
@rkdavies
Copy link

Python 2.4.3 (#1, Nov 11 2010, 13:30:19)
CentOS 5.5 Linux 2.6.18-194.26.1.el5 x86_64 GNU/Linux

Running from one single execution $ ./phenny
21118 pts/8 S+ 0:00 python ./phenny
21119 pts/8 Sl+ 0:00 python ./phenny

[17:29] .auth nick user.name PASSWORD
[17:29] nick is being authenticated.
[17:30] nick is being authenticated.
[17:30] nick authenticated.
[17:30] nick authenticated.

Or I would have to send .quit twice:
[18:56] .quit
[18:56] * PhennyBOT has quit (Quit: PhennyBOT)

---VIEWABLE IN CONSOLE---
... Console log of first execution of phenny ...
Connecting to irc.server.com:6667... connected!
Warning: (in init.py)
Registered modules: tell, wikipedia, validate, remind, info, head, twitter, ping, weather, codepoints, nocbot, wiktionary, cmdb, adminchannel, oblique, clock, admin, reload, translate, snconfig, etymology, search, calc, startup, seen, nocbot, kerberos, cmdb
... command priority and regex output ...
--- I would have to run .quit again to get the bot to exit ---
[18:56] .quit

I am also seeing evidence of this when when I CTRL-C out of the CLI screen session.

LilianaKinsley pushed a commit to LilianaKinsley/PinkiePyBot that referenced this issue Sep 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants