Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likely Bugs in the "Using the O’Neil (2019) Observation-based Priors" Tutorial #381

Open
gabeweible opened this issue Sep 27, 2024 · 0 comments

Comments

@gabeweible
Copy link

Describe the bug

  1. The ObsPrior class in the source code of priors.py appears to want the required arguments ordered as: epochs, ra_err, dec_err, mtot, but the tutorial provides these arguments in the order: ra_err, dec_err, epochs, mtot (in the tutorial, the last of these is the system_mass variable).
  2. The astropy.table.column.Column variable for the error in relative declination, dec_err, should be assigned the value: mySystem.data_table["quant2_err"], but the tutorial assigns: mySystem.data_table["quant1_err"] (i.e., the same astropy.table.column.Column for relative right ascension as assigned to ra_err in the tutorial).

To Reproduce
Go to: Using the O’Neil (2019) Observation-based Priors, Priors to compare argument ordering and see the dec_err assignment in the tutorial.

Screenshots
Screenshot from 2024-09-27 10-06-00
Screenshot from 2024-09-27 10-05-26

Desktop (please complete the following information):

  • orbitize! Version 3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant