Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom MADE class overwriting nflows #1394

Closed
gmoss13 opened this issue Feb 20, 2025 · 0 comments · Fixed by #1398
Closed

Custom MADE class overwriting nflows #1394

gmoss13 opened this issue Feb 20, 2025 · 0 comments · Fixed by #1398
Labels
bug Something isn't working

Comments

@gmoss13
Copy link
Contributor

gmoss13 commented Feb 20, 2025

As discovered in #1269, there is a bug in the nflows implementation of MADE. Until this is patched there, we should overwrite MADE with a temporary fix in sbi
@gmoss13 gmoss13 added the bug Something isn't working label Feb 20, 2025
@gmoss13 gmoss13 mentioned this issue Feb 20, 2025
Merged
@gmoss13 gmoss13 linked a pull request Feb 20, 2025 that will close this issue
Temporary Wrappers to fix MADE #1398
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporary Wrappers to fix MADE sbi-dev/sbi
1 participant
@gmoss13