Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_categoricalmassestimator should have z-score option and perform z-scoring by itself. #1134

Open
michaeldeistler opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@michaeldeistler
Copy link
Contributor

Currently, the build_categoricalmassestimator does not take arguments for z-scoring. Instead, since it is only actively used in MNLE, build_mnle takes care of z-scoring by passing a standarization net to the build_categoricalmassestimator here.

However, if build_categoricalmassestimator is supposed to be used standalone to estimate discrete densities, then this will not work. We should make the API of build_categoricalmassestimator consistent will also other build_xyz() functions and add z-scoring kwargs.

@michaeldeistler michaeldeistler added the enhancement New feature or request label Apr 9, 2024
@janfb janfb self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants