Skip to content

Commit

Permalink
MTN: split linting process from the CI/CD workflow (#1164)
Browse files Browse the repository at this point in the history
  • Loading branch information
tomMoral authored Jun 10, 2024
1 parent 7900af0 commit 66d1f2b
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 32 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,6 @@ concurrency:
cancel-in-progress: true

jobs:
pre-commit:
name: ruff and hooks.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
- uses: pre-commit/[email protected]
with:
extra_args: --all-files --show-diff-on-failure

cd:
name: CD
runs-on: ubuntu-latest
Expand Down Expand Up @@ -54,10 +42,6 @@ jobs:
python -m pip install --upgrade pip
pip install -e .[dev]
- name: Check types with pyright
run: |
pyright sbi
- name: Run the fast and the slow CPU tests with coverage
run: |
pytest -v -x -n auto -m "not gpu" --cov=sbi --cov-report=xml tests/
Expand Down
16 changes: 0 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,6 @@ concurrency:
cancel-in-progress: true

jobs:
pre-commit:
name: ruff and hooks.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
- uses: pre-commit/[email protected]
with:
extra_args: --all-files --show-diff-on-failure

ci:
name: CI
runs-on: ubuntu-latest
Expand Down Expand Up @@ -63,10 +51,6 @@ jobs:
pip install torch==${{ matrix.torch-version }} --extra-index-url https://download.pytorch.org/whl/cpu
pip install -e .[dev]
- name: Check types with pyright
run: |
pyright sbi
- name: Run the fast CPU tests with coverage
run: |
pytest -v -x -n auto -m "not slow and not gpu" --cov=sbi --cov-report=xml tests/
Expand Down
62 changes: 62 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: Linting

on:
pull_request:
push:
branches: [main]
workflow_dispatch:

defaults:
run:
shell: bash

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
pre-commit:
name: ruff and hooks.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
- uses: pre-commit/[email protected]
with:
extra_args: --all-files --show-diff-on-failure

pyright:
name: Check types
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: false

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'

- name: Cache dependency
id: cache-dependencies
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ubuntu-latest-pip-3.8
restore-keys: |
ubuntu-latest-pip-
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install torch --extra-index-url https://download.pytorch.org/whl/cpu
pip install -e .[dev]
- name: Check types with pyright
run: |
pyright sbi

0 comments on commit 66d1f2b

Please sign in to comment.