Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creation of new 'size' tokens #500

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Apr 4, 2024

BEGIN_COMMIT_OVERRIDE
feat: creation of new 'size' tokens

BREAKING CHANGE: some tokens have been removed and some others added; specifically:

  • the following tokens have been removed:
    • --sbb-size-button-m-min-height-<breakpoint>
    • --sbb-size-button-l-min-height-<breakpoint>
    • --sbb-size-form-element-m-min-height-<breakpoint>
    • --sbb-size-form-element-l-min-height-<breakpoint>
    • --sbb-size-touch-min
    • --sbb-size-icon-timetable-attribute
    • --sbb-size-icon-timetable-him-cus
    • --sbb-size-icon-timetable-product-brand
    • --sbb-size-icon-pictograms
    • --sbb-size-icon-form-error
  • the following composed tokens have been removed:
    • --sbb-size-button-m-min-height
    • --sbb-size-button-l-min-height
    • --sbb-size-form-element-m-min-height
    • --sbb-size-form-element-l-min-height
  • the following tokens have been added:
    • --sbb-size-element-xs-<breakpoint>
    • --sbb-size-element-s-<breakpoint>
    • --sbb-size-element-m-<breakpoint>
    • --sbb-size-element-l-<breakpoint>
  • the following composed tokens have been added:
    • --sbb-size-element-xs
    • --sbb-size-element-s
    • --sbb-size-element-m
    • --sbb-size-element-l

END_COMMIT_OVERRIDE

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Apr 4, 2024 that may be closed by this pull request
@DavideMininni-Fincons DavideMininni-Fincons changed the title style: add new token for sbb-form-field size 's' feat(sbb-form-field): add new token for sbb-form-field size 's' Apr 4, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-form-field): add new token for sbb-form-field size 's' feat(sbb-form-field): add new token for size 's' Apr 4, 2024
designTokens/size.ts Outdated Show resolved Hide resolved
designTokens/size.ts Outdated Show resolved Hide resolved
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-form-field): add new token for size 's' feat: creation of new 'size' tokens Apr 4, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat: creation of new 'size' tokens feat: creation of new 'size' tokens Apr 4, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice idea 😃

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DavideMininni-Fincons DavideMininni-Fincons merged commit ced8d75 into main Apr 4, 2024
8 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/token-lean-form-field-size-s branch April 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form-Field: Size S
3 participants