Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-autocomplete): favourites PoC #1772

Closed
wants to merge 132 commits into from

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented May 24, 2023

Changes

Implemented a POC for the autocomplete with favourites component

Known a11y problems

The ARIA pattern we are using is not broadly used and presents some problems:

  • VoiceOver + Chrome => Reads the content of the option only if the previous one has finished speaking (it is needed to navigate slowly)
  • VoiceOver on Safari and iOS is not supported
  • VoiceOver + Chrome => Groups labels are not read
  • JAWS + Firefox => Groups labels are not read
  • Android + TalkBack => Groups labels are not read

TomMenga and others added 30 commits April 17, 2023 11:04
@TomMenga TomMenga changed the title feat(sbb-autocomplete): favourites POC feat(sbb-autocomplete): favorites POC May 24, 2023
@TomMenga TomMenga changed the title feat(sbb-autocomplete): favorites POC feat(sbb-autocomplete): favourites POC May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@9b7780d). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage        ?   53.41%           
=======================================
  Files           ?      161           
  Lines           ?     6375           
  Branches        ?     1749           
=======================================
  Hits            ?     3405           
  Misses          ?     2739           
  Partials        ?      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomMenga TomMenga changed the title feat(sbb-autocomplete): favourites POC feat(sbb-autocomplete): favourites PoC May 25, 2023
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label Feb 5, 2024
@jeripeierSBB
Copy link
Contributor

Continued in #2512

@TomMenga TomMenga deleted the feat/sbb-autocomplete-favourites branch April 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: blocked Pull request is blocked either for merging or reviewing preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants