fix: review

sbb-design-systems · Apr 3, 2024 · 8dedb4f · 8dedb4f
1 parent 2aa0c5c
commit 8dedb4f
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 24 deletions.
diff --git a/...omplete-grid/autocomplete-grid-option/__snapshots__/autocomplete-grid-option.spec.snap.js b/...omplete-grid/autocomplete-grid-option/__snapshots__/autocomplete-grid-option.spec.snap.js
@@ -64,3 +64,35 @@ snapshots["sbb-autocomplete-grid-option default A11y tree Firefox"] =
 `;
 /* end snapshot sbb-autocomplete-grid-option default A11y tree Firefox */
 
+snapshots["sbb-autocomplete-grid-option A11y tree Chrome"] = 
+`<p>
+  {
+  "role": "WebArea",
+  "name": "",
+  "children": [
+    {
+      "role": "text",
+      "name": "Option 1"
+    }
+  ]
+}
+</p>
+`;
+/* end snapshot sbb-autocomplete-grid-option A11y tree Chrome */
+
+snapshots["sbb-autocomplete-grid-option A11y tree Firefox"] = 
+`<p>
+  {
+  "role": "document",
+  "name": "",
+  "children": [
+    {
+      "role": "text leaf",
+      "name": "Option 1"
+    }
+  ]
+}
+</p>
+`;
+/* end snapshot sbb-autocomplete-grid-option A11y tree Firefox */
+
diff --git a/src/components/autocomplete-grid/autocomplete-grid-option/autocomplete-grid-option.spec.ts b/src/components/autocomplete-grid/autocomplete-grid-option/autocomplete-grid-option.spec.ts
@@ -33,12 +33,12 @@ describe('sbb-autocomplete-grid-option', () => {
     it('ShadowDom', async () => {
       await expect(root).shadowDom.to.be.equalSnapshot();
     });
-
-    testA11yTreeSnapshot(
-      html`<sbb-autocomplete-grid-option value="1">Option 1</sbb-autocomplete-grid-option>`,
-    );
   });
 
+  testA11yTreeSnapshot(
+    html`<sbb-autocomplete-grid-option value="1">Option 1</sbb-autocomplete-grid-option>`,
+  );
+
   describe('disabled', () => {
     let root: SbbAutocompleteGridOptionElement;
     beforeEach(async () => {

diff --git a/src/components/autocomplete-grid/autocomplete-grid/autocomplete-grid.spec.ts b/src/components/autocomplete-grid/autocomplete-grid/autocomplete-grid.spec.ts
@@ -1,5 +1,4 @@
 import { expect } from '@open-wc/testing';
-import type { TemplateResult } from 'lit';
 import { html } from 'lit/static-html.js';
 
 import { isSafari } from '../../core/dom';
@@ -15,25 +14,24 @@ import '../autocomplete-grid-button';
 
 describe('sbb-autocomplete-grid', () => {
   let root: SbbAutocompleteGridElement;
-  const grid: TemplateResult = html`
-    <sbb-autocomplete-grid>
-      <sbb-autocomplete-grid-row>
-        <sbb-autocomplete-grid-option>Option 1</sbb-autocomplete-grid-option>
-        <sbb-autocomplete-grid-actions>
-          <sbb-autocomplete-grid-button icon-name="dog-small"></sbb-autocomplete-grid-button>
-        </sbb-autocomplete-grid-actions>
-      </sbb-autocomplete-grid-row>
-      <sbb-autocomplete-grid-row>
-        <sbb-autocomplete-grid-option>Option 2</sbb-autocomplete-grid-option>
-        <sbb-autocomplete-grid-actions>
-          <sbb-autocomplete-grid-button icon-name="dog-small"></sbb-autocomplete-grid-button>
-        </sbb-autocomplete-grid-actions>
-      </sbb-autocomplete-grid-row>
-    </sbb-autocomplete-grid>
-  `;
 
   beforeEach(async () => {
-    root = await fixture(grid);
+    root = await fixture(html`
+      <sbb-autocomplete-grid>
+        <sbb-autocomplete-grid-row>
+          <sbb-autocomplete-grid-option>Option 1</sbb-autocomplete-grid-option>
+          <sbb-autocomplete-grid-actions>
+            <sbb-autocomplete-grid-button icon-name="dog-small"></sbb-autocomplete-grid-button>
+          </sbb-autocomplete-grid-actions>
+        </sbb-autocomplete-grid-row>
+        <sbb-autocomplete-grid-row>
+          <sbb-autocomplete-grid-option>Option 2</sbb-autocomplete-grid-option>
+          <sbb-autocomplete-grid-actions>
+            <sbb-autocomplete-grid-button icon-name="dog-small"></sbb-autocomplete-grid-button>
+          </sbb-autocomplete-grid-actions>
+        </sbb-autocomplete-grid-row>
+      </sbb-autocomplete-grid>
+    `);
   });
 
   describeIf(!isSafari(), 'Chrome-Firefox', async () => {
@@ -45,7 +43,7 @@ describe('sbb-autocomplete-grid', () => {
       await expect(root).shadowDom.to.be.equalSnapshot();
     });
 
-    testA11yTreeSnapshot(grid);
+    testA11yTreeSnapshot();
   });
 
   describeIf(isSafari(), 'Safari', async () => {
@@ -57,6 +55,6 @@ describe('sbb-autocomplete-grid', () => {
       await expect(root).shadowDom.to.be.equalSnapshot();
     });
 
-    testA11yTreeSnapshot(grid);
+    testA11yTreeSnapshot();
   });
 });