Skip to content

Commit

Permalink
fix: rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
DavideMininni-Fincons committed Apr 3, 2024
1 parent c91e488 commit 5985077
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { CSSResultGroup, PropertyValues, TemplateResult } from 'lit';
import type { CSSResultGroup, PropertyValues } from 'lit';
import { customElement } from 'lit/decorators.js';

import { SbbOptionBaseElement } from '../../core/base-elements/option-base-element';
Expand Down Expand Up @@ -79,10 +79,6 @@ export class SbbAutocompleteGridOptionElement extends SbbOptionBaseElement {

this.setSelectedViaUserInteraction(true);
}

protected override render(): TemplateResult {
return super.render();
}
}

declare global {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ let nextId = 0;
* @event {CustomEvent<void>} didOpen - Emits whenever the `sbb-autocomplete-grid` is opened.
* @event {CustomEvent<void>} willClose - Emits whenever the `sbb-autocomplete-grid` begins the closing transition. Can be canceled.
* @event {CustomEvent<void>} didClose - Emits whenever the `sbb-autocomplete-grid` is closed.
* @cssprop [--sbb-autocomplete-z-index=var(--sbb-overlay-z-index)] - To specify a custom stack order,
* @cssprop [--sbb-autocomplete-z-index=var(--sbb-overlay-default-z-index)] - To specify a custom stack order,
* the `z-index` can be overridden by defining this CSS variable. The default `z-index` of the
* component is set to `var(--sbb-overlay-z-index)` with a value of `1000`.
* component is set to `var(--sbb-overlay-default-z-index)` with a value of `1000`.
*/
@customElement('sbb-autocomplete-grid')
@hostAttributes({
Expand Down
6 changes: 3 additions & 3 deletions src/components/autocomplete-grid/autocomplete-grid/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ using `aria-activedescendant` to support navigation though the autocomplete opti

## CSS Properties

| Name | Default | Description |
| ---------------------------- | ---------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `--sbb-autocomplete-z-index` | `var(--sbb-overlay-z-index)` | To specify a custom stack order, the `z-index` can be overridden by defining this CSS variable. The default `z-index` of the component is set to `var(--sbb-overlay-z-index)` with a value of `1000`. |
| Name | Default | Description |
| ---------------------------- | ------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `--sbb-autocomplete-z-index` | `var(--sbb-overlay-default-z-index)` | To specify a custom stack order, the `z-index` can be overridden by defining this CSS variable. The default `z-index` of the component is set to `var(--sbb-overlay-default-z-index)` with a value of `1000`. |

## Slots

Expand Down
2 changes: 1 addition & 1 deletion src/components/core/overlay/overlay-trigger-attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function setAriaComboBoxAttributes(
trigger.setAttribute('aria-autocomplete', 'list');
trigger.setAttribute('aria-haspopup', hasPopup);
trigger.setAttribute('aria-controls', overlayId);
trigger.setAttribute('aria-owns', overlayId); // From Aria 1.2 this should not be necessary but safari still needs it
trigger.setAttribute('aria-owns', overlayId); // From Aria 1.2 this should not be necessary, but safari still needs it
trigger.setAttribute('aria-expanded', `${expanded}`);
}

Expand Down

0 comments on commit 5985077

Please sign in to comment.