Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook into DiscordSRV #22

Open
Etanarvazac opened this issue Sep 12, 2023 · 4 comments
Open

Hook into DiscordSRV #22

Etanarvazac opened this issue Sep 12, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@Etanarvazac
Copy link

DiscordSRV1 listens specifically to the message itself. Upon adding this plugin, DiscordSRV sends [UNCATEGORIZED DEBUG] Not sending death message for <player>, death message is null to the console (whilst debug is on). Even though the message is simply re-written according to this plugin. Could a hook be made for DiscordSRV's death listener2?

Click here DiscordSRV's hook directory.

Footnotes

  1. DiscordSRV GitHub: https://github.com/DiscordSRV/DiscordSRV

  2. Death Listener file: https://github.com/DiscordSRV/DiscordSRV/blob/master/src/main/java/github/scarsz/discordsrv/listeners/PlayerDeathListener.java

@sb2bg
Copy link
Owner

sb2bg commented Sep 25, 2023

The message is not simply rewritten, depending on certain settings, it's more complex. I've looked into it, but their API is poor and will be added when I can figure out the easiest way. EssentialsDiscord has already been implemented on the development branch, and I would like to get DiscordSRV as well before pushing this next update. Thanks!

@sb2bg sb2bg added this to the Version 2.0.2 milestone Sep 25, 2023
@sb2bg sb2bg added the enhancement New feature or request label Sep 25, 2023
@v4rl1
Copy link

v4rl1 commented Feb 7, 2024

Hello, first of all thanks for the awesome plug-in you made ! After trying out diffenret ones, this is clearly the best available.

I also came here to ask the same thing of you, and I was wondering if you were able to figure out a solution ?

If that can be of help, I've seen that AxKills (https://www.spigotmc.org/resources/axkills-customizable-kill-messages.112119/) manages to hook into DiscordSRV, because I tried it before your plug-in.

@v4rl1
Copy link

v4rl1 commented Mar 14, 2024

Hello, just figured another way that could be done which would be simpler on your end I think perhaps.

If you had an API that contained Events it could be read by the alerts feature DiscordSRV already had, and wouldn't need for you to hook into their API

@Etanarvazac
Copy link
Author

Etanarvazac commented Mar 25, 2024

Hello, just figured another way that could be done which would be simpler on your end I think perhaps.

If you had an API that contained Events it could be read by the alerts feature DiscordSRV already had, and wouldn't need for you to hook into their API

That could be possible. I do apologize for the [very] late reply. Been busy with other things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants