Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook into Essentials Discord #17

Open
supertakeru opened this issue Jun 24, 2023 · 7 comments
Open

Hook into Essentials Discord #17

supertakeru opened this issue Jun 24, 2023 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@supertakeru
Copy link

Hello,

I think it would be a great idea to be able to hook onto Discord chat plugins like Essentials Discord to be able to display the death messages on the discord chat.

@sb2bg
Copy link
Owner

sb2bg commented Jun 24, 2023

I'm already working on DiscordSRV. I'm not familiar with Essentials Discord? I tried looking it up but I couldn't really see much about it. Is it similar to DiscordSRV?

Also, I've told someone this before but it makes a lot more sense for it to be left here:

The (DiscordSRV) API doesn't allow me to hook and add support by myself, so I've contacted their developers. This could take as long as they want, or never. Now, there is no other solution to this without interaction from their end, so I may eventually make a pull request depending on their response.

@supertakeru
Copy link
Author

It is made by the EssentialsX team and it is really similar to DiscordSRV. https://essentialsx.net/wiki/Discord-Tutorial.html I think they have a developer API on this link.

@sb2bg
Copy link
Owner

sb2bg commented Jun 25, 2023

Ahh, yes, they have message channels for death that I can hook into. Thanks for the suggestion. Expect it by next update hopefully.

@sb2bg sb2bg added the enhancement New feature or request label Jun 25, 2023
@sb2bg sb2bg added this to the Version 2.0.2 milestone Jun 25, 2023
@supertakeru
Copy link
Author

god blast you sir

@sb2bg
Copy link
Owner

sb2bg commented Jun 25, 2023

I've already implemented it, I just need to test it now

@supertakeru
Copy link
Author

How is the testing going?

@sb2bg
Copy link
Owner

sb2bg commented Jul 2, 2023

Essentials Discord works fully, waiting on DiscordSRV implementation. Ideally, they will be bundled into one update. I'm out of town, so I don't have an ETA currently. Thanks for being patient!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants