Fact for determining rsyslog version needlessly increases runtime by 1 second on RHEL

[nick-george]

Please see this line:

https://github.com/saz/puppet-rsyslog/blob/master/lib/facter/rsyslog_version.rb#L22

Is there any need to run rpm -qa instead of rpm -q? See the difference in time for the two executions below. They both give the same result.

time /bin/rpm -qa --qf "%{VERSION}" "rsyslog"
7.4.7
real	0m0.914s
user	0m0.855s
sys	0m0.057s

time /bin/rpm -q --qf "%{VERSION}" "rsyslog"
7.4.7
real	0m0.070s
user	0m0.063s
sys	0m0.005s

[otheus]

Bump. Trivial fix.

[otheus]

Fixed (by someone else) in ed6609f . Please release new version/tag.

[otheus]

Further optimization can be made to line 19. Replace head|awk|sed with just sed.

rsyslogd -v | sed -n '2q; s/^[^ ]* \([0-9][^ ]*\).*/\1/; s/,//g;p'

Translation:

• -n no output unless requested by p
• quit at line 2
• find the first instance of <digit>-<non-space>* after the first space; replace the line with it.
• strip , characters
• print the line