Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash button not showing on some devices #122

Open
rsanjuan87 opened this issue Feb 10, 2023 · 17 comments
Open

Flash button not showing on some devices #122

rsanjuan87 opened this issue Feb 10, 2023 · 17 comments

Comments

@rsanjuan87
Copy link
Contributor

Is there a way to turn on the flash when scanning to get better results?

@hieudc110501
Copy link

the same question

@sawankumarbundelkhandi
Copy link
Owner

@rsanjuan87 are these flash button not working for you?

ios -
image

android -
image

@hieudc110501
Copy link

hieudc110501 commented Mar 6, 2023

Thanks, but why i can't see flash button in my android device ? @sawankumarbundelkhandi

image

@rsanjuan87
Copy link
Contributor Author

rsanjuan87 commented Mar 6, 2023

Nothing here either
https://user-images.githubusercontent.com/25087943/223077814-cfd58827-c49d-4aff-8ae9-c5cecd2fd92d.jpg

@hieudc110501
Copy link

Nothing here either Screenshot_2023-03-06-10-57-58-170_com.contappdigital.scanner.dev_fl.jpg

The same me

@hieudc110501
Copy link

I solved this problem. Change a bit in android/src/main/kotlin/com/sample/edgedetection/scan/ScanActivity.kt
image

@rsanjuan87
Copy link
Contributor Author

sorry but, what have you changed?

@rsanjuan87 rsanjuan87 changed the title support to turn on the flash ? Flash button not showing on some devices Mar 19, 2023
@hieudc110501
Copy link

@rsanjuan87 set flash.visibility = View.VISIBLE

@sawankumarbundelkhandi
Copy link
Owner

@hieudc110501 can you do a PR of your fix?

@githuseyingur
Copy link

Hi, I can't try this fix because I can't access the native code of the edge_detection package, can you help?

@muhammedhosgor
Copy link

Hey, I have the same problem @githuseyingur, the android/src/main/kotlin/com/sample/edgedetection/scan/ScanActivity.kt directory is not present in my code. How can I access the source code of the edge_detection package? pub dev: https://pub.dev/packages/edge_detection

@sawankumarbundelkhandi
Copy link
Owner

@muhammedhosgor here is the file - https://github.com/sawankumarbundelkhandi/edge_detection/blob/master/android/src/main/kotlin/com/sample/edgedetection/scan/ScanActivity.kt.

You can fork the project and change the code and then use that fork in your flutter project.

@githuseyingur
Copy link

@sawankumarbundelkhandi Oh, it seems to be fixed in the new update(version 1.1.3). Thank you very much. <3

@muhammedhosgor
Copy link

@sawankumarbundelkhandi It works fine after the update. Thank you very much for a successful package :)

@sawankumarbundelkhandi
Copy link
Owner

@rsanjuan87 @hieudc110501 can you please also check and confirm? I will close the issue then.

@anilkumar416
Copy link

still flash option is not working any fix ?

@anilkumar416
Copy link

@sawankumarbundelkhandi is issue still not resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants