From 3d57737221acca3f9e038806c1cb03ff08a7da05 Mon Sep 17 00:00:00 2001 From: Bernie Gray Date: Mon, 8 May 2023 22:11:48 -0400 Subject: [PATCH 1/2] assign return value of syscall.Kill() to err --- main.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main.go b/main.go index 93dfbfd..d5891d9 100644 --- a/main.go +++ b/main.go @@ -204,11 +204,12 @@ func getProcesses() []list.Item { } func killPort(pid string) { + var err error pidInt, err := strconv.Atoi(pid) if err != nil { log.Error("Could not convert to process pid to int") } - syscall.Kill(pidInt, syscall.SIGKILL) + err = syscall.Kill(pidInt, syscall.SIGKILL) if err != nil { log.Error("Could not kill process") } From 193fa8ed1486be5151a50ed95c84e1c4cbc5aae7 Mon Sep 17 00:00:00 2001 From: Bernie Gray Date: Mon, 8 May 2023 22:12:43 -0400 Subject: [PATCH 2/2] return early from killPort() if strconv.Atoi() fails --- main.go | 1 + 1 file changed, 1 insertion(+) diff --git a/main.go b/main.go index d5891d9..abaae31 100644 --- a/main.go +++ b/main.go @@ -208,6 +208,7 @@ func killPort(pid string) { pidInt, err := strconv.Atoi(pid) if err != nil { log.Error("Could not convert to process pid to int") + return } err = syscall.Kill(pidInt, syscall.SIGKILL) if err != nil {