Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic] color_current_row takes precedence over color_column_sep #2653

Open
mhoirup opened this issue Dec 26, 2024 · 3 comments
Open

[cosmetic] color_current_row takes precedence over color_column_sep #2653

mhoirup opened this issue Dec 26, 2024 · 3 comments
Labels

Comments

@mhoirup
Copy link

mhoirup commented Dec 26, 2024

A small thing: the foreground color of the column separators gets overwritten by the foreground color of the current row. Would it be possible to have color_current_row ignore the column separators all together? In the picture you can see how the separators are colored white on the current row, even though I've specified a different color for separators.

Screenshot 2024-12-26 at 15 09 35
@mhoirup mhoirup changed the title [cosmetic] color_current_cell takes precedence over color_column_sep [cosmetic] color_current_row takes precedence over color_column_sep Dec 26, 2024
@midichef
Copy link
Contributor

For people who want to try out this proposed change, change the line in sheets.py:

basecellcattr = sepcattr = update_attr(rowcattr, color_current_row)

to not assign to sepcattr:

                basecellcattr = update_attr(rowcattr, color_current_row)

I'm too used to the existing behavior. So I can't tell what most users would prefer.

@mhoirup
Copy link
Author

mhoirup commented Dec 27, 2024

Thank you so much @midichef! Worked like a charm. I also defined my own color for the current row separators and used that in sheets.py like so:

Screenshot 2024-12-27 at 11 02 39

The result is, in my subjective opinion, a much cleaner look:

Screenshot 2024-12-27 at 11 01 16

@saulpw
Copy link
Owner

saulpw commented Dec 28, 2024

This was an intentional choice. If the background colors are different, the cursor row won't be continuous unless the color_current_row takes precedence. I don't know what the solution is here to make us both happy. Maybe the default 'reverse' is the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants