New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make visidata.Path more Path-like #2188

Open

2 of 4 tasks

saulpw opened this issue Dec 24, 2023 · 1 comment

Labels

Owner

saulpw commented Dec 24, 2023 •

edited

Loading

Path.name should be the full filename (instead of just the base stem)
add visidata.Path.base_stem to be the filename without any suffixes (same as current visidata.Path.name)
change all current uses of visidata.Path.name to visidata.Path.base_stem
pathlib.Path.iterdir() returns a generator instead of a list

saulpw added the wishlist label

Owner Author

saulpw commented Dec 24, 2023

Most of vd internally now uses visidata.Path.base_stem instead of .name. The remainder are row.name when the rowdef is Path, e.g. directories.

saulpw added a commit that referenced this issue


          [vgit-] use .stem for non-visidata.Path #2188

2cedecd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment