Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain and Model modules vs business logic module #3

Open
pedrovgs opened this issue Feb 15, 2015 · 2 comments
Open

Domain and Model modules vs business logic module #3

pedrovgs opened this issue Feb 15, 2015 · 2 comments
Assignees

Comments

@pedrovgs
Copy link

Hi Saul! Thanks for your time to prepare this article and this repository!!

I'd like to comment some things to know your opinion:

In this article you use "domain" and "model" as a separated concept when most of the authors use "domain model" to talk about all the classes related to your business logic and abstractions needed to model the problem. Your "model" module is used to retrieve data from an external API and you comment that in the future will be used to persist data. The responsibility of this "model" module is more related to a repository or two different modules like one api client and one storage. In addition, I see your class TvMovie created in your "model" module is used from your "app" module, doing this you are coupling your "app" and "domain" module to the code related to the API Client and the persistence. Don't you prefer to move that entities to your business logic layer. What do you think?

@saulmm saulmm self-assigned this Feb 15, 2015
@olegflo
Copy link

olegflo commented Feb 22, 2015

Subscribed to your discussion, interesting to follow this.

when most of the authors use "domain model" to talk about all the classes related to your business logic and abstractions needed to model the problem

Could you please provide some authoritative references, would like to investigate deeper.

@pedrovgs
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants